[Data] Move env_float, env_integer, and env_bool to ray._common by DeborahOlaboye · Pull Request #60642 · ray-project/ray

DeborahOlaboye · 2026-02-01T08:17:13Z

Description

Move env_integer, env_float, and env_bool utility functions from ray._private.ray_constants to ray._common.utils. Update all Ray Data imports to use the new location.

Related issues

Fixes #60516

gemini-code-assist

Code Review

This pull request refactors the env_integer, env_float, and env_bool utility functions by moving them from ray._private.ray_constants to ray._common.utils. The changes across the codebase correctly update the import paths to reflect this move.

My review focuses on the implementation of the moved functions. I've identified a correctness issue in env_integer where it fails to handle negative integer values from environment variables. I've also suggested a minor improvement to env_bool for better readability and to avoid redundant lookups. The implementation of env_float looks good.

python/ray/_common/utils.py

gemini-code-assist · 2026-02-01T08:19:50Z

python/ray/_common/utils.py

+def env_bool(key, default):
+    if key in os.environ:
+        return (
+            True
+            if os.environ[key].lower() == "true" or os.environ[key] == "1"
+            else False
+        )
+    return default


The current implementation accesses os.environ[key] multiple times within the conditional logic. This can be slightly improved for efficiency and readability by storing the value in a local variable before performing comparisons.

def env_bool(key, default): if key in os.environ: val = os.environ[key].lower() return val == "true" or val == "1" return default

python/ray/data/_internal/cluster_autoscaler/default_autoscaling_coordinator.py

iamjustinhsu · 2026-02-04T18:55:46Z

Hi @DeborahOlaboye, can you rebase + fix the tests?

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

python/ray/_common/utils.py

DeborahOlaboye · 2026-02-04T20:25:08Z

Hi @DeborahOlaboye, can you rebase + fix the tests?

Thanks for the review. I've addressed the tests and also rebased the branch.

bveeramani

Nice, ty

Signed-off-by: DeborahOlaboye <deboraholaboye@gmail.com>

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

edoakes · 2026-02-10T14:21:32Z

pushed a commit to fix linter

…project#60642) ## Description Move `env_integer`, `env_float`, and `env_bool` utility functions from `ray._private.ray_constants` to `ray._common.utils`. Update all Ray Data imports to use the new location. ## Related issues Fixes ray-project#60516 --------- Signed-off-by: DeborahOlaboye <deboraholaboye@gmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: Ondrej Prenek <ondra.prenek@gmail.com>

…project#60642) ## Description Move `env_integer`, `env_float`, and `env_bool` utility functions from `ray._private.ray_constants` to `ray._common.utils`. Update all Ray Data imports to use the new location. ## Related issues Fixes ray-project#60516 --------- Signed-off-by: DeborahOlaboye <deboraholaboye@gmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com>

…project#60642) ## Description Move `env_integer`, `env_float`, and `env_bool` utility functions from `ray._private.ray_constants` to `ray._common.utils`. Update all Ray Data imports to use the new location. ## Related issues Fixes ray-project#60516 --------- Signed-off-by: DeborahOlaboye <deboraholaboye@gmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: Muhammad Saif <2024BBIT200@student.Uet.edu.pk>

…project#60642) Move `env_integer`, `env_float`, and `env_bool` utility functions from `ray._private.ray_constants` to `ray._common.utils`. Update all Ray Data imports to use the new location. Fixes ray-project#60516 --------- Signed-off-by: DeborahOlaboye <deboraholaboye@gmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com>

…project#60642) ## Description Move `env_integer`, `env_float`, and `env_bool` utility functions from `ray._private.ray_constants` to `ray._common.utils`. Update all Ray Data imports to use the new location. ## Related issues Fixes ray-project#60516 --------- Signed-off-by: DeborahOlaboye <deboraholaboye@gmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: Adel Nour <ans9868@nyu.edu>

…project#60642) ## Description Move `env_integer`, `env_float`, and `env_bool` utility functions from `ray._private.ray_constants` to `ray._common.utils`. Update all Ray Data imports to use the new location. ## Related issues Fixes ray-project#60516 --------- Signed-off-by: DeborahOlaboye <deboraholaboye@gmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com>

…project#60642) ## Description Move `env_integer`, `env_float`, and `env_bool` utility functions from `ray._private.ray_constants` to `ray._common.utils`. Update all Ray Data imports to use the new location. ## Related issues Fixes ray-project#60516 --------- Signed-off-by: DeborahOlaboye <deboraholaboye@gmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>

…project#60642) ## Description Move `env_integer`, `env_float`, and `env_bool` utility functions from `ray._private.ray_constants` to `ray._common.utils`. Update all Ray Data imports to use the new location. ## Related issues Fixes ray-project#60516 --------- Signed-off-by: DeborahOlaboye <deboraholaboye@gmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com>

DeborahOlaboye requested review from a team, edoakes and jjyao as code owners February 1, 2026 08:17

gemini-code-assist bot reviewed Feb 1, 2026

View reviewed changes

cursor bot reviewed Feb 1, 2026

View reviewed changes

python/ray/data/_internal/cluster_autoscaler/default_autoscaling_coordinator.py Outdated Show resolved Hide resolved

ray-gardener bot added data Ray Data-related issues community-contribution Contributed by the community labels Feb 1, 2026

DeborahOlaboye force-pushed the move-env-utils-to-common branch from 9089e1c to a121905 Compare February 4, 2026 20:18

cursor bot reviewed Feb 4, 2026

View reviewed changes

python/ray/_common/utils.py Show resolved Hide resolved

bveeramani self-assigned this Feb 4, 2026

bveeramani approved these changes Feb 10, 2026

View reviewed changes

DeborahOlaboye force-pushed the move-env-utils-to-common branch from a121905 to 700d1ff Compare February 10, 2026 07:00

[Data] Move env_float, env_integer, and env_bool to ray._common

ed1d2c9

Signed-off-by: DeborahOlaboye <deboraholaboye@gmail.com>

DeborahOlaboye force-pushed the move-env-utils-to-common branch from 700d1ff to ed1d2c9 Compare February 10, 2026 07:01

edoakes added the go add ONLY when ready to merge, run all tests label Feb 10, 2026

edoakes approved these changes Feb 10, 2026

View reviewed changes

lint

194a95b

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

edoakes enabled auto-merge (squash) February 10, 2026 14:21

Merge branch 'master' into move-env-utils-to-common

396b5b4

github-actions bot disabled auto-merge February 10, 2026 16:18

bveeramani enabled auto-merge (squash) February 10, 2026 18:28

bveeramani merged commit c08329b into ray-project:master Feb 11, 2026
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Data] Move env_float, env_integer, and env_bool to ray._common#60642

[Data] Move env_float, env_integer, and env_bool to ray._common#60642
bveeramani merged 3 commits intoray-project:masterfrom
DeborahOlaboye:move-env-utils-to-common

DeborahOlaboye commented Feb 1, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot Feb 1, 2026

Uh oh!

Uh oh!

iamjustinhsu commented Feb 4, 2026

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

DeborahOlaboye commented Feb 4, 2026

Uh oh!

bveeramani left a comment

Uh oh!

edoakes commented Feb 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

DeborahOlaboye commented Feb 1, 2026

Description

Related issues

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iamjustinhsu commented Feb 4, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DeborahOlaboye commented Feb 4, 2026

Uh oh!

bveeramani left a comment

Choose a reason for hiding this comment

Uh oh!

edoakes commented Feb 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants