Skip to content

[Data] Remove deprecated TENSOR_COLUMN_NAME constant and associated dead code [1]#60573

Merged
bveeramani merged 30 commits intoray-project:masterfrom
Hyunoh-Yeo:in-progress-60547
Feb 3, 2026
Merged

[Data] Remove deprecated TENSOR_COLUMN_NAME constant and associated dead code [1]#60573
bveeramani merged 30 commits intoray-project:masterfrom
Hyunoh-Yeo:in-progress-60547

Conversation

@Hyunoh-Yeo
Copy link
Copy Markdown
Contributor

@Hyunoh-Yeo Hyunoh-Yeo commented Jan 28, 2026

Description

Remove safe TENSOR_COLUMN_NAME related

Related issues

Related to #60547

Additional information

  • Remove TENSOR_COLUMN_NAME from arrow_block, pandas_block, and table_block.py.

Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
.
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
.
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
.
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the deprecated TENSOR_COLUMN_NAME constant and cleans up associated dead code and backward compatibility logic across several files. The changes are well-contained and align with the goal of simplifying the codebase. I have one minor suggestion to update a type hint for better code clarity and correctness.

Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
@Hyunoh-Yeo Hyunoh-Yeo marked this pull request as ready for review January 29, 2026 03:47
@Hyunoh-Yeo Hyunoh-Yeo requested a review from a team as a code owner January 29, 2026 03:47
@Hyunoh-Yeo Hyunoh-Yeo marked this pull request as draft January 29, 2026 04:26
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
@Hyunoh-Yeo Hyunoh-Yeo marked this pull request as ready for review January 30, 2026 14:14
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
@ray-gardener ray-gardener bot added data Ray Data-related issues community-contribution Contributed by the community labels Jan 30, 2026
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
@Hyunoh-Yeo Hyunoh-Yeo changed the title [Data] Remove deprecated TENSOR_COLUMN_NAME constant and associated dead code [Data] Remove deprecated TENSOR_COLUMN_NAME constant and associated dead code [1] Jan 31, 2026
Hyunoh-Yeo and others added 3 commits January 30, 2026 19:08
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Copy link
Copy Markdown
Member

@bveeramani bveeramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the PR description to give a bit more context? Just a couple lines on (1) why we're making this change, and (2) how this PR fits in with the rest planned

output_array = _convert_pandas_to_batch_type(
actual_output, type=BatchFormat.NUMPY, cast_tensor_columns=cast_tensor_columns
)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could you remove the unrelated whitespace to minimize the size of the diff?

@bveeramani bveeramani added the go add ONLY when ready to merge, run all tests label Feb 3, 2026
@bveeramani bveeramani enabled auto-merge (squash) February 3, 2026 07:10
@bveeramani bveeramani merged commit ebf82c7 into ray-project:master Feb 3, 2026
7 checks passed
rayhhome pushed a commit to rayhhome/ray that referenced this pull request Feb 4, 2026
…ead code [1] (ray-project#60573)

## Description
Remove safe TENSOR_COLUMN_NAME related

## Related issues
Related to ray-project#60547

## Additional information
- Remove TENSOR_COLUMN_NAME from arrow_block, pandas_block, and
table_block.py.

---------

Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Sirui Huang <ray.huang@anyscale.com>
@Hyunoh-Yeo Hyunoh-Yeo deleted the in-progress-60547 branch February 4, 2026 09:19
Sparks0219 pushed a commit to Sparks0219/ray that referenced this pull request Feb 9, 2026
…ead code [1] (ray-project#60573)

## Description
Remove safe TENSOR_COLUMN_NAME related 

## Related issues
Related to ray-project#60547 

## Additional information
- Remove TENSOR_COLUMN_NAME from arrow_block, pandas_block, and
table_block.py.

---------

Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Feb 9, 2026
…ead code [1] (#60573)

## Description
Remove safe TENSOR_COLUMN_NAME related 

## Related issues
Related to #60547 

## Additional information
- Remove TENSOR_COLUMN_NAME from arrow_block, pandas_block, and
table_block.py.

---------

Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Feb 9, 2026
…ead code [1] (#60573)

## Description
Remove safe TENSOR_COLUMN_NAME related 

## Related issues
Related to #60547 

## Additional information
- Remove TENSOR_COLUMN_NAME from arrow_block, pandas_block, and
table_block.py.

---------

Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
ans9868 pushed a commit to ans9868/ray that referenced this pull request Feb 18, 2026
…ead code [1] (ray-project#60573)

## Description
Remove safe TENSOR_COLUMN_NAME related

## Related issues
Related to ray-project#60547

## Additional information
- Remove TENSOR_COLUMN_NAME from arrow_block, pandas_block, and
table_block.py.

---------

Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Adel Nour <ans9868@nyu.edu>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
…ead code [1] (ray-project#60573)

## Description
Remove safe TENSOR_COLUMN_NAME related

## Related issues
Related to ray-project#60547

## Additional information
- Remove TENSOR_COLUMN_NAME from arrow_block, pandas_block, and
table_block.py.

---------

Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
…ead code [1] (ray-project#60573)

## Description
Remove safe TENSOR_COLUMN_NAME related

## Related issues
Related to ray-project#60547

## Additional information
- Remove TENSOR_COLUMN_NAME from arrow_block, pandas_block, and
table_block.py.

---------

Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community data Ray Data-related issues go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants