[Serve] Expose health metrics from controller#60473
Merged
abrarsheikh merged 12 commits intomasterfrom Jan 29, 2026
Merged
Conversation
Signed-off-by: abrar <abrar@anyscale.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive health metrics tracking system for the Serve controller. A new ControllerHealthMetricsTracker is added to collect various performance indicators like control loop duration, event loop delay, and memory usage. These metrics are then exposed via a new get_health_metrics method on the controller. The changes are well-implemented and include thorough unit and integration tests.
My main feedback is to improve the cross-platform compatibility of the memory usage calculation, which is currently only correct for Linux. I've left a specific suggestion to address this.
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
harshit-anyscale
approved these changes
Jan 28, 2026
jinbum-kim
pushed a commit
to jinbum-kim/ray
that referenced
this pull request
Jan 29, 2026
Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
limarkdcunha
pushed a commit
to limarkdcunha/ray
that referenced
this pull request
Jan 29, 2026
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Feb 1, 2026
Signed-off-by: 400Ping <jiekaichang@apache.org>
ans9868
pushed a commit
to ans9868/ray
that referenced
this pull request
Feb 18, 2026
Signed-off-by: Adel Nour <ans9868@nyu.edu>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
Signed-off-by: peterxcli <peterxcli@gmail.com>
abrarsheikh
added a commit
that referenced
this pull request
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
get_health_metrics()API to the Serve controller and aserve controller-healthCLI command to expose performance metrics that help diagnose controller issues as cluster size increases.Test Plan
DurationStats,ControllerHealthMetrics,ControllerHealthMetricsTrackerget_health_metrics()APIserve controller-health