Conversation
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
aslonnie
approved these changes
Jan 21, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly updates a code example in the writing-code-snippets.rst documentation to match the new ray.data.Dataset string representation. The changes, including updating the .. testoutput:: block and using np.round for cleaner output, are accurate and improve the documentation. I have one minor suggestion to improve the readability of the example code.
Comment on lines
156
to
+158
| vec_a = batch["petal length (cm)"] | ||
| vec_b = batch["petal width (cm)"] | ||
| batch["petal area (cm^2)"] = vec_a * vec_b | ||
| batch["petal area (cm^2)"] = np.round(vec_a * vec_b, 2) |
Contributor
There was a problem hiding this comment.
For better readability and to set a good example in this guide on writing code snippets, consider using more descriptive variable names instead of vec_a and vec_b. For example, petal_length and petal_width would make the code's intent clearer.
Suggested change
| vec_a = batch["petal length (cm)"] | |
| vec_b = batch["petal width (cm)"] | |
| batch["petal area (cm^2)"] = vec_a * vec_b | |
| batch["petal area (cm^2)"] = np.round(vec_a * vec_b, 2) | |
| petal_length = batch["petal length (cm)"] | |
| petal_width = batch["petal width (cm)"] | |
| batch["petal area (cm^2)"] = np.round(petal_length * petal_width, 2) |
aslonnie
reviewed
Jan 21, 2026
| │ --- ┆ --- ┆ --- ┆ --- ┆ --- ┆ --- │ | ||
| │ double ┆ double ┆ double ┆ double ┆ int64 ┆ double │ | ||
| ╞═══════════════════╪══════════════════╪═══════════════════╪══════════════════╪════════╪═══════════════════╡ | ||
| │ 5.1 ┆ 3.5 ┆ 1.4 ┆ 0.2 ┆ 0 ┆ 0.28 │ |
Collaborator
There was a problem hiding this comment.
these are some very specific data.
Member
Author
There was a problem hiding this comment.
It's the data in the canonical Iris dataset. We should enable preserve_order for Data doctest, so these results should be deterministic
richardliaw
approved these changes
Jan 21, 2026
Contributor
richardliaw
left a comment
There was a problem hiding this comment.
any reason how this wasn't caught in earlier tests?
Member
Author
|
@richardliaw I guess the contributor guide doctests don't run on Data premerge |
abrarsheikh
pushed a commit
that referenced
this pull request
Jan 21, 2026
#59631 changed the way the `Dataset` representations look, but CI didn't test `writing-code-snippet` in that PR's premerge CI. This PR fixes the incorrect output. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: abrar <abrar@anyscale.com>
jinbum-kim
pushed a commit
to jinbum-kim/ray
that referenced
this pull request
Jan 29, 2026
…project#60351) ray-project#59631 changed the way the `Dataset` representations look, but CI didn't test `writing-code-snippet` in that PR's premerge CI. This PR fixes the incorrect output. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Feb 1, 2026
…project#60351) ray-project#59631 changed the way the `Dataset` representations look, but CI didn't test `writing-code-snippet` in that PR's premerge CI. This PR fixes the incorrect output. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: 400Ping <jiekaichang@apache.org>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
…project#60351) ray-project#59631 changed the way the `Dataset` representations look, but CI didn't test `writing-code-snippet` in that PR's premerge CI. This PR fixes the incorrect output. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…project#60351) ray-project#59631 changed the way the `Dataset` representations look, but CI didn't test `writing-code-snippet` in that PR's premerge CI. This PR fixes the incorrect output. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…project#60351) ray-project#59631 changed the way the `Dataset` representations look, but CI didn't test `writing-code-snippet` in that PR's premerge CI. This PR fixes the incorrect output. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#59631 changed the way the
Datasetrepresentations look, but CI didn't testwriting-code-snippetin that PR's premerge CI. This PR fixes the incorrect output.