[Data] Use metrics from OpRuntimeMetrics for Progress#60304
Merged
bveeramani merged 1 commit intoray-project:masterfrom Jan 20, 2026
Merged
[Data] Use metrics from OpRuntimeMetrics for Progress#60304bveeramani merged 1 commit intoray-project:masterfrom
OpRuntimeMetrics for Progress#60304bveeramani merged 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: Daniel Shin <kyuseung1016@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a good refactoring that removes the redundant output_row_count field from OpState and uses the row_outputs_taken metric from OpRuntimeMetrics instead. This change simplifies state management and improves code clarity by eliminating a duplicate counter. The update is consistently applied across all progress bar implementations (logging, rich, and tqdm). The logic appears sound, and I approve of this change.
bveeramani
approved these changes
Jan 20, 2026
jinbum-kim
pushed a commit
to jinbum-kim/ray
that referenced
this pull request
Jan 29, 2026
…60304) ## Description We had a separate field in `OpState` to keep track of outputted rows. `OpRuntimeMetrics` exist per `PhysicalOperator`, and also has a field to keep track of outputted rows, so there is no need to keep track of a duplicate in OpState. ## Related issues N/A ## Additional information N/A Signed-off-by: Daniel Shin <kyuseung1016@gmail.com> Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Feb 1, 2026
…60304) ## Description We had a separate field in `OpState` to keep track of outputted rows. `OpRuntimeMetrics` exist per `PhysicalOperator`, and also has a field to keep track of outputted rows, so there is no need to keep track of a duplicate in OpState. ## Related issues N/A ## Additional information N/A Signed-off-by: Daniel Shin <kyuseung1016@gmail.com> Signed-off-by: 400Ping <jiekaichang@apache.org>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
…60304) ## Description We had a separate field in `OpState` to keep track of outputted rows. `OpRuntimeMetrics` exist per `PhysicalOperator`, and also has a field to keep track of outputted rows, so there is no need to keep track of a duplicate in OpState. ## Related issues N/A ## Additional information N/A Signed-off-by: Daniel Shin <kyuseung1016@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…60304) ## Description We had a separate field in `OpState` to keep track of outputted rows. `OpRuntimeMetrics` exist per `PhysicalOperator`, and also has a field to keep track of outputted rows, so there is no need to keep track of a duplicate in OpState. ## Related issues N/A ## Additional information N/A Signed-off-by: Daniel Shin <kyuseung1016@gmail.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…60304) ## Description We had a separate field in `OpState` to keep track of outputted rows. `OpRuntimeMetrics` exist per `PhysicalOperator`, and also has a field to keep track of outputted rows, so there is no need to keep track of a duplicate in OpState. ## Related issues N/A ## Additional information N/A Signed-off-by: Daniel Shin <kyuseung1016@gmail.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We had a separate field in
OpStateto keep track of outputted rows.OpRuntimeMetricsexist perPhysicalOperator, and also has a field to keep track of outputted rows, so there is no need to keep track of a duplicate in OpState.Related issues
N/A
Additional information
N/A