Revert "[Data] Add configurable batching for resolve_block_refs to sp…#60114
Merged
alexeykudinkin merged 1 commit intoray-project:masterfrom Jan 13, 2026
Merged
Conversation
…eed up iter_batches (ray-project#58467)" This reverts commit 2a042d4. Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
7d78ccd to
bd662d6
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that introduced configurable batching for resolve_block_refs. The revert appears to be clean and complete, correctly removing the feature logic, configuration, and associated tests. I have one minor suggestion to improve code clarity and avoid redundant calls in iter_batches.py.
Comment on lines
+136
to
144
| self._eager_free = ( | ||
| clear_block_after_read and DataContext.get_current().eager_free | ||
| ) | ||
|
|
||
| actor_prefetcher_enabled = ( | ||
| prefetch_batches > 0 | ||
| and self._ctx.actor_prefetcher_enabled | ||
| and DataContext.get_current().actor_prefetcher_enabled | ||
| and not ray.util.client.ray.is_connected() | ||
| ) |
Contributor
There was a problem hiding this comment.
To avoid multiple calls to DataContext.get_current(), you could store the context in a local variable at the beginning of the method and reuse it. This improves readability and avoids repeated function calls.
ctx = DataContext.get_current()
self._eager_free = (
clear_block_after_read and ctx.eager_free
)
actor_prefetcher_enabled = (
prefetch_batches > 0
and ctx.actor_prefetcher_enabled
and not ray.util.client.ray.is_connected()
)
Contributor
Author
|
Hey @YoussefEssDS, we had to revert this PR because the hurts performance when using
If you have any questions, feel free to reach out. You can also join the external ray data slack channel and we chat over there too |
alexeykudinkin
approved these changes
Jan 13, 2026
Closed
rushikeshadhav
pushed a commit
to rushikeshadhav/ray
that referenced
this pull request
Jan 14, 2026
ray-project#60114) …eed up iter_batches (ray-project#58467)" This reverts commit 2a042d4. ## Description Reverts # 58467 ## Related issues ## Additional information Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
jeffery4011
pushed a commit
to jeffery4011/ray
that referenced
this pull request
Jan 20, 2026
ray-project#60114) …eed up iter_batches (ray-project#58467)" This reverts commit 2a042d4. ## Description Reverts # 58467 ## Related issues ## Additional information Signed-off-by: iamjustinhsu <jhsu@anyscale.com> Signed-off-by: jeffery4011 <jefferyshen1015@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
ray-project#60114) …eed up iter_batches (ray-project#58467)" This reverts commit 2a042d4. ## Description Reverts # 58467 ## Related issues ## Additional information Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
ray-project#60114) …eed up iter_batches (ray-project#58467)" This reverts commit 2a042d4. ## Description Reverts # 58467 ## Related issues ## Additional information Signed-off-by: iamjustinhsu <jhsu@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
ray-project#60114) …eed up iter_batches (ray-project#58467)" This reverts commit 2a042d4. ## Description Reverts # 58467 ## Related issues ## Additional information Signed-off-by: iamjustinhsu <jhsu@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eed up iter_batches (#58467)"
This reverts commit 2a042d4.
Description
Reverts # 58467
Related issues
Additional information