[Data] add explicit args for mocking _AutoscalingCoordinatorActor#60037
Merged
bveeramani merged 4 commits intoray-project:masterfrom Jan 13, 2026
Merged
[Data] add explicit args for mocking _AutoscalingCoordinatorActor#60037bveeramani merged 4 commits intoray-project:masterfrom
_AutoscalingCoordinatorActor#60037bveeramani merged 4 commits intoray-project:masterfrom
Conversation
Signed-off-by: machichima <nary12321@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the _AutoscalingCoordinatorActor to accept explicit arguments for its dependencies (get_current_time, send_resources_request, get_cluster_nodes), which is a great improvement for testability and maintainability. This change allows for clean dependency injection in tests, removing the need for unittest.mock.patch. The implementation is well-executed, and the corresponding test files have been updated to leverage this new approach. The changes are correct and improve the overall code quality. I have no further suggestions as the code looks good.
Signed-off-by: machichima <nary12321@gmail.com>
Contributor
Author
|
@bveeramani PTAL. Thank you! |
bveeramani
approved these changes
Jan 12, 2026
Comment on lines
+97
to
+102
| global MOCKED_TIME | ||
| MOCKED_TIME = 0 | ||
|
|
||
| mock_request_resources = Mock() | ||
| as_coordinator = _AutoscalingCoordinatorActor( | ||
| get_current_time=mock_time, |
Member
There was a problem hiding this comment.
I know this is the existing behavior, but do we need to use a global variable for this? Using a global variable for testing seems unideal
Can we just use a local variable?
Suggested change
| global MOCKED_TIME | |
| MOCKED_TIME = 0 | |
| mock_request_resources = Mock() | |
| as_coordinator = _AutoscalingCoordinatorActor( | |
| get_current_time=mock_time, | |
| mocked_time = 0 | |
| mock_request_resources = Mock() | |
| as_coordinator = _AutoscalingCoordinatorActor( | |
| get_current_time=lambda: mocked_time, |
Contributor
Author
There was a problem hiding this comment.
Oh yes! I've modified in aa9d428
Also changes other place that use this and removed mock_time() and MOCKED_TIME as they are not used anymore
Signed-off-by: machichima <nary12321@gmail.com>
rushikeshadhav
pushed a commit
to rushikeshadhav/ray
that referenced
this pull request
Jan 14, 2026
…ay-project#60037) ## Description As mentioned in ray-project#59740 (comment), add explicit args in `_AutoscalingCoordinatorActor` constructor to improve maintainability. ## Related issues Follow-up: ray-project#59740 ## Additional information - Pass in mock function in testing as args rather than using `patch` --------- Signed-off-by: machichima <nary12321@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
jeffery4011
pushed a commit
to jeffery4011/ray
that referenced
this pull request
Jan 20, 2026
…ay-project#60037) ## Description As mentioned in ray-project#59740 (comment), add explicit args in `_AutoscalingCoordinatorActor` constructor to improve maintainability. ## Related issues Follow-up: ray-project#59740 ## Additional information - Pass in mock function in testing as args rather than using `patch` --------- Signed-off-by: machichima <nary12321@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: jeffery4011 <jefferyshen1015@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
…ay-project#60037) ## Description As mentioned in ray-project#59740 (comment), add explicit args in `_AutoscalingCoordinatorActor` constructor to improve maintainability. ## Related issues Follow-up: ray-project#59740 ## Additional information - Pass in mock function in testing as args rather than using `patch` --------- Signed-off-by: machichima <nary12321@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…ay-project#60037) ## Description As mentioned in ray-project#59740 (comment), add explicit args in `_AutoscalingCoordinatorActor` constructor to improve maintainability. ## Related issues Follow-up: ray-project#59740 ## Additional information - Pass in mock function in testing as args rather than using `patch` --------- Signed-off-by: machichima <nary12321@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…ay-project#60037) ## Description As mentioned in ray-project#59740 (comment), add explicit args in `_AutoscalingCoordinatorActor` constructor to improve maintainability. ## Related issues Follow-up: ray-project#59740 ## Additional information - Pass in mock function in testing as args rather than using `patch` --------- Signed-off-by: machichima <nary12321@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #59740 (comment), add explicit args in
_AutoscalingCoordinatorActorconstructor to improve maintainability.Related issues
Follow-up: #59740
Additional information
patch