[Data] Make StatefulShuffleAggregation.finalize interface allow incremental streaming#59972
Merged
alexeykudinkin merged 1 commit intomasterfrom Jan 8, 2026
Merged
[Data] Make StatefulShuffleAggregation.finalize interface allow incremental streaming#59972alexeykudinkin merged 1 commit intomasterfrom
StatefulShuffleAggregation.finalize interface allow incremental streaming#59972alexeykudinkin merged 1 commit intomasterfrom
Conversation
…l streaming Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the StatefulShuffleAggregation.finalize interface to support incremental streaming by changing its return type to Iterator[Block]. The implementations in ReducingShuffleAggregation, Concat, and JoiningShuffleAggregation are updated to yield blocks. The logic in HashShuffleAggregator is also refactored to consume this new iterator, improving how execution stats are handled for multiple output blocks. The changes are well-aligned with the goal of preparing for incremental streaming. My review includes a suggestion to remove an unused attribute in JoiningShuffleAggregation.
| partition_id: ArrowBlockBuilder() for partition_id in target_partition_ids | ||
| } | ||
| self.data_context = data_context | ||
| self._data_context = data_context |
Contributor
There was a problem hiding this comment.
The _data_context attribute is assigned but never used within the JoiningShuffleAggregation class. It seems to be dead code. Consider removing this attribute and the corresponding data_context parameter from the __init__ method signature to improve code clarity. This would also require removing the data_context argument from the call site in JoinOperator.
elliot-barn
pushed a commit
that referenced
this pull request
Jan 11, 2026
…remental streaming (#59972) ## Description This change makes `StatefulShuffleAggregation.finalize` interface allow incremental streaming to prepare it for future shift to streaming results incrementally. ## Related issues > Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
AYou0207
pushed a commit
to AYou0207/ray
that referenced
this pull request
Jan 13, 2026
…remental streaming (ray-project#59972) ## Description This change makes `StatefulShuffleAggregation.finalize` interface allow incremental streaming to prepare it for future shift to streaming results incrementally. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
lee1258561
pushed a commit
to pinterest/ray
that referenced
this pull request
Feb 3, 2026
…remental streaming (ray-project#59972) ## Description This change makes `StatefulShuffleAggregation.finalize` interface allow incremental streaming to prepare it for future shift to streaming results incrementally. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
…remental streaming (ray-project#59972) ## Description This change makes `StatefulShuffleAggregation.finalize` interface allow incremental streaming to prepare it for future shift to streaming results incrementally. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…remental streaming (ray-project#59972) ## Description This change makes `StatefulShuffleAggregation.finalize` interface allow incremental streaming to prepare it for future shift to streaming results incrementally. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…remental streaming (ray-project#59972) ## Description This change makes `StatefulShuffleAggregation.finalize` interface allow incremental streaming to prepare it for future shift to streaming results incrementally. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change makes
StatefulShuffleAggregation.finalizeinterface allow incremental streaming to prepare it for future shift to streaming results incrementally.Related issues
Additional information