[Data] Compute Expressions-Expr Rounding#59295
Merged
alexeykudinkin merged 2 commits intoray-project:masterfrom Dec 17, 2025
Merged
[Data] Compute Expressions-Expr Rounding#59295alexeykudinkin merged 2 commits intoray-project:masterfrom
alexeykudinkin merged 2 commits intoray-project:masterfrom
Conversation
Signed-off-by: yaommen <myanstu@163.com>
94c1046 to
7081bb0
Compare
Member
Author
|
Hi, @goutamvenkat-anyscale ,Could you please review this PR when you have time?many thanks |
Contributor
|
hey @myandpr, thanks a bunch for the contribution! if you're interested in chatting more with the contributors, feel free to join our community sync -- https://docs.google.com/forms/d/e/1FAIpQLSeYWjNExnr6gbhO5rpM0i6wm4TBTdsm3y5S0LR8Syzk_2gelQ/viewform |
Member
Author
@richardliaw Submitted the form! Looking forward to the next sync meeting.Looking forward to contributing more and learning from everyone. |
Collaborator
|
@bveeramani PTAL |
goutamvenkat-anyscale
requested changes
Dec 16, 2025
Contributor
goutamvenkat-anyscale
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Just a few comments
bveeramani
reviewed
Dec 16, 2025
Member
bveeramani
left a comment
There was a problem hiding this comment.
LGTM other than Goutam's suggestions
Signed-off-by: yaommen <myanstu@163.com>
goutamvenkat-anyscale
approved these changes
Dec 17, 2025
Contributor
goutamvenkat-anyscale
left a comment
There was a problem hiding this comment.
lgtm! Thanks
zzchun
pushed a commit
to zzchun/ray
that referenced
this pull request
Dec 18, 2025
### Description
Completing the Expr (direct) Rounding operations (ceil, floor, round,
trunc)
for example:
```
import ray
from ray.data import from_items
from ray.data.expressions import col
ray.init(include_dashboard=False, ignore_reinit_error=True)
ds = from_items([{"x": 1.1}, {"x": 2.5}, {"x": -3.7}])
for row in ds.iter_rows():
print(row)
x_expr = col("x")
hasattr(x_expr, "ceil")
ds = ds.with_column("x_ceil", x_expr.ceil())
hasattr(x_expr, "floor")
ds = ds.with_column("x_floor", x_expr.floor())
hasattr(x_expr, "round")
ds = ds.with_column("x_round", x_expr.round())
hasattr(x_expr, "trunc")
ds = ds.with_column("x_trunc", x_expr.trunc())
for row in ds.iter_rows():
print(row)
```
### Related issues
Related to ray-project#58674
### Additional information
---------
Signed-off-by: yaommen <myanstu@163.com>
Co-authored-by: yanmin <homeryan@didiglobal.com>
Yicheng-Lu-llll
pushed a commit
to Yicheng-Lu-llll/ray
that referenced
this pull request
Dec 22, 2025
### Description
Completing the Expr (direct) Rounding operations (ceil, floor, round,
trunc)
for example:
```
import ray
from ray.data import from_items
from ray.data.expressions import col
ray.init(include_dashboard=False, ignore_reinit_error=True)
ds = from_items([{"x": 1.1}, {"x": 2.5}, {"x": -3.7}])
for row in ds.iter_rows():
print(row)
x_expr = col("x")
hasattr(x_expr, "ceil")
ds = ds.with_column("x_ceil", x_expr.ceil())
hasattr(x_expr, "floor")
ds = ds.with_column("x_floor", x_expr.floor())
hasattr(x_expr, "round")
ds = ds.with_column("x_round", x_expr.round())
hasattr(x_expr, "trunc")
ds = ds.with_column("x_trunc", x_expr.trunc())
for row in ds.iter_rows():
print(row)
```
### Related issues
Related to ray-project#58674
### Additional information
---------
Signed-off-by: yaommen <myanstu@163.com>
Co-authored-by: yanmin <homeryan@didiglobal.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
### Description
Completing the Expr (direct) Rounding operations (ceil, floor, round,
trunc)
for example:
```
import ray
from ray.data import from_items
from ray.data.expressions import col
ray.init(include_dashboard=False, ignore_reinit_error=True)
ds = from_items([{"x": 1.1}, {"x": 2.5}, {"x": -3.7}])
for row in ds.iter_rows():
print(row)
x_expr = col("x")
hasattr(x_expr, "ceil")
ds = ds.with_column("x_ceil", x_expr.ceil())
hasattr(x_expr, "floor")
ds = ds.with_column("x_floor", x_expr.floor())
hasattr(x_expr, "round")
ds = ds.with_column("x_round", x_expr.round())
hasattr(x_expr, "trunc")
ds = ds.with_column("x_trunc", x_expr.trunc())
for row in ds.iter_rows():
print(row)
```
### Related issues
Related to ray-project#58674
### Additional information
---------
Signed-off-by: yaommen <myanstu@163.com>
Co-authored-by: yanmin <homeryan@didiglobal.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completing the Expr (direct) Rounding operations (ceil, floor, round, trunc)
for example:
Related issues
Related to #58674
Additional information