[Data] Fix empty block sort in hash shuffle operator#58836
Merged
bveeramani merged 1 commit intomasterfrom Nov 20, 2025
Merged
Conversation
Prevent calling sort_by on empty blocks in the Concat finalize method. Attempting to sort an empty block can cause errors or unnecessary overhead. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a safeguard in the Concat.finalize method to prevent sorting empty blocks within the hash shuffle operator. By adding a check to ensure the block is not empty before attempting to sort, this change improves robustness and prevents potential errors or unnecessary overhead when processing empty partitions. The implementation is correct and well-contained. I approve this change.
iamjustinhsu
approved these changes
Nov 20, 2025
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Nov 21, 2025
## Description Prevent calling `sort_by` on empty blocks in the `Concat.finalize` method. Attempting to sort an empty block can cause unnecessary overhead. This change adds a check to ensure the block has data before attempting to sort. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
## Description Prevent calling `sort_by` on empty blocks in the `Concat.finalize` method. Attempting to sort an empty block can cause unnecessary overhead. This change adds a check to ensure the block has data before attempting to sort. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
## Description Prevent calling `sort_by` on empty blocks in the `Concat.finalize` method. Attempting to sort an empty block can cause unnecessary overhead. This change adds a check to ensure the block has data before attempting to sort. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
## Description Prevent calling `sort_by` on empty blocks in the `Concat.finalize` method. Attempting to sort an empty block can cause unnecessary overhead. This change adds a check to ensure the block has data before attempting to sort. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent calling
sort_byon empty blocks in theConcat.finalizemethod. Attempting to sort an empty block can cause unnecessary overhead. This change adds a check to ensure the block has data before attempting to sort.