[Data] Set udf-modifying-row-count default to false#58264
Merged
alexeykudinkin merged 1 commit intoray-project:masterfrom Oct 29, 2025
Merged
Conversation
494d193 to
c0aa88c
Compare
owenowenisme
commented
Oct 29, 2025
| isinstance(current_op, AbstractOneToOne) | ||
| and not current_op.can_modify_num_rows() | ||
| ): | ||
| if isinstance(current_op, AbstractMap): |
Member
Author
There was a problem hiding this comment.
One thing worth mention is that we shouldnt push through those _min_rows_per_bundled_input is < limit or it will break some behavior, for example, the schema api 's limit(1) shouldn't push through if it is used with map_batches(batch_size=2)
alexeykudinkin
approved these changes
Oct 29, 2025
| if min_rows is not None and min_rows > limit_op._limit: | ||
| # Avoid pushing the limit past batch-based maps that require more | ||
| # rows than the limit to produce stable outputs (e.g. schema). | ||
| break |
Contributor
There was a problem hiding this comment.
Let's add a log statement here to be able to trace this from the logs
alexeykudinkin
pushed a commit
that referenced
this pull request
Oct 30, 2025
…imit` (#58303) ## Description ## Related issues Fix comment #58264 (comment) ## Additional information Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
YoussefEssDS
pushed a commit
to YoussefEssDS/ray
that referenced
this pull request
Nov 8, 2025
…imit` (ray-project#58303) ## Description ## Related issues Fix comment ray-project#58264 (comment) ## Additional information Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…imit` (ray-project#58303) ## Description ## Related issues Fix comment ray-project#58264 (comment) ## Additional information Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…imit` (ray-project#58303) ## Description ## Related issues Fix comment ray-project#58264 (comment) ## Additional information Signed-off-by: You-Cheng Lin <mses010108@gmail.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…imit` (ray-project#58303) ## Description ## Related issues Fix comment ray-project#58264 (comment) ## Additional information Signed-off-by: You-Cheng Lin <mses010108@gmail.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…imit` (ray-project#58303) ## Description ## Related issues Fix comment ray-project#58264 (comment) ## Additional information Signed-off-by: You-Cheng Lin <mses010108@gmail.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We want to keep the limit pushdown as default so we should set
udf_modifying_row_countdefault to false as default.Related issues
Additional information