Skip to content

[train] Turn on Train v2 by default#57857

Merged
justinvyu merged 2 commits intoray-project:masterfrom
justinvyu:flipswitchforreal
Oct 17, 2025
Merged

[train] Turn on Train v2 by default#57857
justinvyu merged 2 commits intoray-project:masterfrom
justinvyu:flipswitchforreal

Conversation

@justinvyu
Copy link
Copy Markdown
Contributor

Description

Release tests, unit tests, doctests, and examples are all migrated to V2, so this PR turns V2 on by default. To run with Train V1 (deprecated), set RAY_TRAIN_V2_ENABLED=0.

Related issues

#49454

Additional information

User guides and API references have already been updated to V2.

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu requested a review from a team as a code owner October 17, 2025 20:17
@justinvyu justinvyu added the go add ONLY when ready to merge, run all tests label Oct 17, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly enables Ray Train v2 by default by changing the default value for the RAY_TRAIN_V2_ENABLED environment variable. The change is straightforward and aligns with the migration to v2 as described. I have one suggestion to add a docstring to the is_v2_enabled function to improve code clarity and maintainability, making the new default behavior explicit.

Copy link
Copy Markdown
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMdXhUR

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu requested a review from a team as a code owner October 17, 2025 22:16
@justinvyu justinvyu enabled auto-merge (squash) October 17, 2025 22:20
@justinvyu justinvyu merged commit 338ae52 into ray-project:master Oct 17, 2025
7 checks passed
@justinvyu justinvyu deleted the flipswitchforreal branch October 17, 2025 23:27
justinyeh1995 pushed a commit to justinyeh1995/ray that referenced this pull request Oct 20, 2025
Release tests, unit tests, doctests, and examples are all migrated to
V2, so this PR turns V2 on by default. To run with Train V1
(deprecated), set `RAY_TRAIN_V2_ENABLED=0`.

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
xinyuangui2 pushed a commit to xinyuangui2/ray that referenced this pull request Oct 22, 2025
Release tests, unit tests, doctests, and examples are all migrated to
V2, so this PR turns V2 on by default. To run with Train V1
(deprecated), set `RAY_TRAIN_V2_ENABLED=0`.

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: xgui <xgui@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Oct 23, 2025
Release tests, unit tests, doctests, and examples are all migrated to
V2, so this PR turns V2 on by default. To run with Train V1
(deprecated), set `RAY_TRAIN_V2_ENABLED=0`.

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
Release tests, unit tests, doctests, and examples are all migrated to
V2, so this PR turns V2 on by default. To run with Train V1
(deprecated), set `RAY_TRAIN_V2_ENABLED=0`.

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
Release tests, unit tests, doctests, and examples are all migrated to
V2, so this PR turns V2 on by default. To run with Train V1
(deprecated), set `RAY_TRAIN_V2_ENABLED=0`.

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier pushed a commit to Future-Outlier/ray that referenced this pull request Dec 7, 2025
Release tests, unit tests, doctests, and examples are all migrated to
V2, so this PR turns V2 on by default. To run with Train V1
(deprecated), set `RAY_TRAIN_V2_ENABLED=0`.

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants