[Serve] fix that rank logs are spammy#57831
Merged
abrarsheikh merged 1 commit intoray-project:masterfrom Oct 17, 2025
Merged
Conversation
…rank reassignment and configuration steps in `deployment_state.py` Change-Id: Idc61828f1686086feb88119a1242dd9c57438d13 Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the issue of spammy rank-related logs by changing their level from INFO to DEBUG. The changes are applied consistently across various scenarios, such as rank assignment, reconfiguration, and reallocation. This will improve the signal-to-noise ratio in the logs during normal operation, while still providing detailed information for debugging purposes. The changes are correct and align with the stated goal. Well done.
Contributor
|
i suggest doing a manual run of the app, observe the controller logs and ensure that there are no other source of logs. |
Contributor
Author
Could you please share the code to reproduce the issue? Thank you. |
Contributor
look at test_replica_rank.py, the logs in the GH are from the controller. so after you run |
Contributor
Author
|
@abrarsheikh Follow your guidance! Thanks!
There are logs related to
There are not logs related to
logs related to The app code is from https://docs.ray.io/en/latest/serve/getting_started.html#running-a-ray-serve-application. |
abrarsheikh
approved these changes
Oct 17, 2025
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
## Description This PR changes 7 rank related INFO level logs in `python/ray/serve/_private/deployment_state.py` to DEBUG level. These logs primarily appear in the following scenarios: 1. When assigning a rank to a new replica 2. When reconfiguring a replica's rank 3. When rank reallocation is completed 4. When discontinuous ranks are detected and minimal reallocation is performed These logs will only be displayed when debugging is needed, and will not affect log output during normal operation. ## Related issues Closes ray-project#57807 The logs in the screenshot from the issue have all been adjusted to DEBUG level. Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
## Description This PR changes 7 rank related INFO level logs in `python/ray/serve/_private/deployment_state.py` to DEBUG level. These logs primarily appear in the following scenarios: 1. When assigning a rank to a new replica 2. When reconfiguring a replica's rank 3. When rank reallocation is completed 4. When discontinuous ranks are detected and minimal reallocation is performed These logs will only be displayed when debugging is needed, and will not affect log output during normal operation. ## Related issues Closes ray-project#57807 The logs in the screenshot from the issue have all been adjusted to DEBUG level. Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: xgui <xgui@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
## Description This PR changes 7 rank related INFO level logs in `python/ray/serve/_private/deployment_state.py` to DEBUG level. These logs primarily appear in the following scenarios: 1. When assigning a rank to a new replica 2. When reconfiguring a replica's rank 3. When rank reallocation is completed 4. When discontinuous ranks are detected and minimal reallocation is performed These logs will only be displayed when debugging is needed, and will not affect log output during normal operation. ## Related issues Closes #57807 The logs in the screenshot from the issue have all been adjusted to DEBUG level. Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
## Description This PR changes 7 rank related INFO level logs in `python/ray/serve/_private/deployment_state.py` to DEBUG level. These logs primarily appear in the following scenarios: 1. When assigning a rank to a new replica 2. When reconfiguring a replica's rank 3. When rank reallocation is completed 4. When discontinuous ranks are detected and minimal reallocation is performed These logs will only be displayed when debugging is needed, and will not affect log output during normal operation. ## Related issues Closes ray-project#57807 The logs in the screenshot from the issue have all been adjusted to DEBUG level. Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
## Description This PR changes 7 rank related INFO level logs in `python/ray/serve/_private/deployment_state.py` to DEBUG level. These logs primarily appear in the following scenarios: 1. When assigning a rank to a new replica 2. When reconfiguring a replica's rank 3. When rank reallocation is completed 4. When discontinuous ranks are detected and minimal reallocation is performed These logs will only be displayed when debugging is needed, and will not affect log output during normal operation. ## Related issues Closes ray-project#57807 The logs in the screenshot from the issue have all been adjusted to DEBUG level. Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
## Description This PR changes 7 rank related INFO level logs in `python/ray/serve/_private/deployment_state.py` to DEBUG level. These logs primarily appear in the following scenarios: 1. When assigning a rank to a new replica 2. When reconfiguring a replica's rank 3. When rank reallocation is completed 4. When discontinuous ranks are detected and minimal reallocation is performed These logs will only be displayed when debugging is needed, and will not affect log output during normal operation. ## Related issues Closes ray-project#57807 The logs in the screenshot from the issue have all been adjusted to DEBUG level. Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Future-Outlier <eric901201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes 7 rank related INFO level logs in
python/ray/serve/_private/deployment_state.pyto DEBUG level. These logs primarily appear in the following scenarios:These logs will only be displayed when debugging is needed, and will not affect log output during normal operation.
Related issues
Closes #57807
The logs in the screenshot from the issue have all been adjusted to DEBUG level.