[train] Fix py312 GPU test filter#57559
Merged
justinvyu merged 1 commit intoray-project:masterfrom Oct 8, 2025
Merged
Conversation
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
| --python-version {{matrix.python}} | ||
| --build-name mlgpubuild-py{{matrix.python}} | ||
| --only-tags gpu | ||
| --only-tags gpu,train_v2_gpu |
There was a problem hiding this comment.
Bug: Duplicate GPU Tests Across Jobs
The ml: train v1 gpu tests job now includes train_v2_gpu in its --only-tags. This change causes tests tagged with train_v2_gpu to run in both this job and a dedicated train v2 gpu tests job, resulting in duplicate execution and wasted CI resources.
Contributor
Author
There was a problem hiding this comment.
The purpose of the py312 job is to duplicate the other tests that usually run in a lower py version.
matthewdeng
approved these changes
Oct 8, 2025
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a CI configuration issue where GPU tests were running on a CPU-only test runner. The changes to include train_v2_gpu in the GPU test suite and exclude it from the CPU test suite are logical and directly address the problem described. I've added a couple of suggestions to potentially remove a now-legacy gpu tag for improved clarity, based on the information in the PR description. Overall, this is a good, targeted fix.
| --workers 4 --worker-id {{matrix.worker_id}} --parallelism-per-worker 3 | ||
| --python-version {{matrix.python}} | ||
| --except-tags gpu,minimal,doctest,needs_credentials,soft_imports,rllib | ||
| --except-tags gpu,train_v2_gpu,minimal,doctest,needs_credentials,soft_imports,rllib |
Contributor
There was a problem hiding this comment.
Based on the PR description, gpu tags were replaced with train_v2_gpu. If the gpu tag is no longer in use, we could remove it from this list to improve clarity and avoid maintaining a legacy tag. This would make it clear that train_v2_gpu is the new standard for these tests.
If the gpu tag is still in use for some tests, then this change is correct as is. In that case, it might be helpful to clarify in the PR summary that both tags are active.
--except-tags train_v2_gpu,minimal,doctest,needs_credentials,soft_imports,rllib
Contributor
Author
There was a problem hiding this comment.
"gpu" tag is still in use for v1 gpu tests.
liulehui
pushed a commit
to liulehui/ray
that referenced
this pull request
Oct 9, 2025
ray-project#56868 replaced `gpu` tags with `train_v2_gpu` in order to separate out the tests into 2 CI pipelines. However, there's a py312 test that only runs in postmerge that filters out the `gpu` tag. This resulted in GPU tests running on the py312 CPU test runner. This PR fixes the issue by filtering out the new `train_v2_gpu` tag as well. Signed-off-by: Justin Yu <justinvyu@anyscale.com>
joshkodi
pushed a commit
to joshkodi/ray
that referenced
this pull request
Oct 13, 2025
ray-project#56868 replaced `gpu` tags with `train_v2_gpu` in order to separate out the tests into 2 CI pipelines. However, there's a py312 test that only runs in postmerge that filters out the `gpu` tag. This resulted in GPU tests running on the py312 CPU test runner. This PR fixes the issue by filtering out the new `train_v2_gpu` tag as well. Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Josh Kodi <joshkodi@gmail.com>
ArturNiederfahrenhorst
pushed a commit
to ArturNiederfahrenhorst/ray
that referenced
this pull request
Oct 13, 2025
ray-project#56868 replaced `gpu` tags with `train_v2_gpu` in order to separate out the tests into 2 CI pipelines. However, there's a py312 test that only runs in postmerge that filters out the `gpu` tag. This resulted in GPU tests running on the py312 CPU test runner. This PR fixes the issue by filtering out the new `train_v2_gpu` tag as well. Signed-off-by: Justin Yu <justinvyu@anyscale.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
ray-project#56868 replaced `gpu` tags with `train_v2_gpu` in order to separate out the tests into 2 CI pipelines. However, there's a py312 test that only runs in postmerge that filters out the `gpu` tag. This resulted in GPU tests running on the py312 CPU test runner. This PR fixes the issue by filtering out the new `train_v2_gpu` tag as well. Signed-off-by: Justin Yu <justinvyu@anyscale.com>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
ray-project#56868 replaced `gpu` tags with `train_v2_gpu` in order to separate out the tests into 2 CI pipelines. However, there's a py312 test that only runs in postmerge that filters out the `gpu` tag. This resulted in GPU tests running on the py312 CPU test runner. This PR fixes the issue by filtering out the new `train_v2_gpu` tag as well. Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: xgui <xgui@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
#56868 replaced `gpu` tags with `train_v2_gpu` in order to separate out the tests into 2 CI pipelines. However, there's a py312 test that only runs in postmerge that filters out the `gpu` tag. This resulted in GPU tests running on the py312 CPU test runner. This PR fixes the issue by filtering out the new `train_v2_gpu` tag as well. Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
ray-project#56868 replaced `gpu` tags with `train_v2_gpu` in order to separate out the tests into 2 CI pipelines. However, there's a py312 test that only runs in postmerge that filters out the `gpu` tag. This resulted in GPU tests running on the py312 CPU test runner. This PR fixes the issue by filtering out the new `train_v2_gpu` tag as well. Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
ray-project#56868 replaced `gpu` tags with `train_v2_gpu` in order to separate out the tests into 2 CI pipelines. However, there's a py312 test that only runs in postmerge that filters out the `gpu` tag. This resulted in GPU tests running on the py312 CPU test runner. This PR fixes the issue by filtering out the new `train_v2_gpu` tag as well. Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
ray-project#56868 replaced `gpu` tags with `train_v2_gpu` in order to separate out the tests into 2 CI pipelines. However, there's a py312 test that only runs in postmerge that filters out the `gpu` tag. This resulted in GPU tests running on the py312 CPU test runner. This PR fixes the issue by filtering out the new `train_v2_gpu` tag as well. Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#56868 replaced
gputags withtrain_v2_gpuin order to separate out the tests into 2 CI pipelines. However, there's a py312 test that only runs in postmerge that filters out thegputag. This resulted in GPU tests running on the py312 CPU test runner. This PR fixes the issue by filtering out the newtrain_v2_gputag as well.