Conversation
so that logic can conditionally execute or skip for doc building Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
| global _PYARROW_VERSION_VALIDATED | ||
|
|
||
| if os.environ.get("RAY_DOC_BUILD", "0") == "1": | ||
| return |
There was a problem hiding this comment.
Bug: PyArrow Version Check Skips Validation
When RAY_DOC_BUILD=1, _check_pyarrow_version() returns early without setting _PYARROW_VERSION_VALIDATED. This causes the PyArrow version check to re-execute on subsequent calls during doc builds, despite the intention to skip validation after the initial check.
There was a problem hiding this comment.
Code Review
This pull request introduces a RAY_DOC_BUILD environment variable to conditionally skip logic during documentation builds. This is used to bypass pyarrow version checks. However, the removal of ray.air.util.tensor_extensions and ray.data._internal.arrow_ops from autodoc_mock_imports is premature, as these modules still contain code that will fail if pyarrow is not installed. I've left a comment with a suggestion to revert this part of the change.
| "ray.serve.generated", | ||
| "ray.air.util.tensor_extensions", | ||
| "ray.data._internal.arrow_ops", | ||
| ] |
There was a problem hiding this comment.
Removing ray.air.util.tensor_extensions and ray.data._internal.arrow_ops from autodoc_mock_imports is premature. While _check_pyarrow_version is patched to not run during doc builds, other functions like get_pyarrow_version are not, and they are used in these modules. This will cause a TypeError during doc builds when pyarrow is not installed, as get_pyarrow_version will return None which cannot be compared to a Version object.
A more complete fix would be to also make get_pyarrow_version in ray/_private/arrow_utils.py aware of the RAY_DOC_BUILD environment variable. For now, I suggest re-adding these modules to the mock list to prevent breaking the doc build.
"ray.air.util.tensor_extensions",
"ray.data._internal.arrow_ops",
]|
I am merging this... will ask for forgiveness laster. |
so that logic can conditionally execute or skip for doc building fixes doc build failure introduced by ray-project#56918 Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
so that logic can conditionally execute or skip for doc building fixes doc build failure introduced by ray-project#56918 Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Seiji Eicher <seiji@anyscale.com>
so that logic can conditionally execute or skip for doc building fixes doc build failure introduced by ray-project#56918 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
so that logic can conditionally execute or skip for doc building fixes doc build failure introduced by ray-project#56918 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
so that logic can conditionally execute or skip for doc building fixes doc build failure introduced by ray-project#56918 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
so that logic can conditionally execute or skip for doc building fixes doc build failure introduced by ray-project#56918 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
so that logic can conditionally execute or skip for doc building fixes doc build failure introduced by ray-project#56918 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
so that logic can conditionally execute or skip for doc building fixes doc build failure introduced by ray-project#56918 Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Josh Kodi <joshkodi@gmail.com>
so that logic can conditionally execute or skip for doc building fixes doc build failure introduced by ray-project#56918 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
so that logic can conditionally execute or skip for doc building fixes doc build failure introduced by ray-project#56918 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
so that logic can conditionally execute or skip for doc building fixes doc build failure introduced by ray-project#56918 Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
so that logic can conditionally execute or skip for doc building fixes doc build failure introduced by ray-project#56918 Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
so that logic can conditionally execute or skip for doc building
fixes doc build failure introduced by #56918