[data] Abstractions for joins#57022
Merged
alexeykudinkin merged 1 commit intoray-project:masterfrom Oct 1, 2025
Merged
Conversation
Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
de49c44 to
74ae0a3
Compare
| ): | ||
| unsupported.append(idx) | ||
| else: | ||
| supported.append(idx) |
There was a problem hiding this comment.
Bug: PyArrow Extension Types Incorrectly Unjoinable
The _split_unsupported_columns method incorrectly treats all PyArrow extension types as unjoinable. It lost the logic to unwrap extension types to their storage type, which means types with joinable underlying data are now unnecessarily indexed. This can break joins or degrade performance.
goutamvenkat-anyscale
approved these changes
Oct 1, 2025
eicherseiji
pushed a commit
to eicherseiji/ray
that referenced
this pull request
Oct 6, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? as titled, does some refractoring to override joins in the future <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Refactors join execution to split preprocessing/postprocessing, encapsulate helper logic as class methods, and standardize index column handling. > > - **Join execution refactor**: > - Introduce `_DatasetPreprocessingResult` for splitting tables into `supported_projection` and `unsupported_projection`. > - Add `_preprocess` and `_postprocess` flow in `finalize()` to handle supported-column joins and restore unsupported columns. > - Convert helper utilities to instance methods: `_split_unsupported_columns`, `_append_index_column`, `_add_back_unsupported_columns`, `_is_pa_join_not_supported`. > - Standardize index column naming via `_index_name(suffix)` and remove hardcoded names. > - Maintain join verb mapping and join semantics while reorganizing logic. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 74ae0a3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Signed-off-by: iamjustinhsu <jhsu@anyscale.com> Signed-off-by: Seiji Eicher <seiji@anyscale.com>
dstrodtman
pushed a commit
to dstrodtman/ray
that referenced
this pull request
Oct 6, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? as titled, does some refractoring to override joins in the future <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Refactors join execution to split preprocessing/postprocessing, encapsulate helper logic as class methods, and standardize index column handling. > > - **Join execution refactor**: > - Introduce `_DatasetPreprocessingResult` for splitting tables into `supported_projection` and `unsupported_projection`. > - Add `_preprocess` and `_postprocess` flow in `finalize()` to handle supported-column joins and restore unsupported columns. > - Convert helper utilities to instance methods: `_split_unsupported_columns`, `_append_index_column`, `_add_back_unsupported_columns`, `_is_pa_join_not_supported`. > - Standardize index column naming via `_index_name(suffix)` and remove hardcoded names. > - Maintain join verb mapping and join semantics while reorganizing logic. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 74ae0a3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Signed-off-by: iamjustinhsu <jhsu@anyscale.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
liulehui
pushed a commit
to liulehui/ray
that referenced
this pull request
Oct 9, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? as titled, does some refractoring to override joins in the future <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Refactors join execution to split preprocessing/postprocessing, encapsulate helper logic as class methods, and standardize index column handling. > > - **Join execution refactor**: > - Introduce `_DatasetPreprocessingResult` for splitting tables into `supported_projection` and `unsupported_projection`. > - Add `_preprocess` and `_postprocess` flow in `finalize()` to handle supported-column joins and restore unsupported columns. > - Convert helper utilities to instance methods: `_split_unsupported_columns`, `_append_index_column`, `_add_back_unsupported_columns`, `_is_pa_join_not_supported`. > - Standardize index column naming via `_index_name(suffix)` and remove hardcoded names. > - Maintain join verb mapping and join semantics while reorganizing logic. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 74ae0a3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
joshkodi
pushed a commit
to joshkodi/ray
that referenced
this pull request
Oct 13, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? as titled, does some refractoring to override joins in the future <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Refactors join execution to split preprocessing/postprocessing, encapsulate helper logic as class methods, and standardize index column handling. > > - **Join execution refactor**: > - Introduce `_DatasetPreprocessingResult` for splitting tables into `supported_projection` and `unsupported_projection`. > - Add `_preprocess` and `_postprocess` flow in `finalize()` to handle supported-column joins and restore unsupported columns. > - Convert helper utilities to instance methods: `_split_unsupported_columns`, `_append_index_column`, `_add_back_unsupported_columns`, `_is_pa_join_not_supported`. > - Standardize index column naming via `_index_name(suffix)` and remove hardcoded names. > - Maintain join verb mapping and join semantics while reorganizing logic. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 74ae0a3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Signed-off-by: iamjustinhsu <jhsu@anyscale.com> Signed-off-by: Josh Kodi <joshkodi@gmail.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? as titled, does some refractoring to override joins in the future <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Refactors join execution to split preprocessing/postprocessing, encapsulate helper logic as class methods, and standardize index column handling. > > - **Join execution refactor**: > - Introduce `_DatasetPreprocessingResult` for splitting tables into `supported_projection` and `unsupported_projection`. > - Add `_preprocess` and `_postprocess` flow in `finalize()` to handle supported-column joins and restore unsupported columns. > - Convert helper utilities to instance methods: `_split_unsupported_columns`, `_append_index_column`, `_add_back_unsupported_columns`, `_is_pa_join_not_supported`. > - Standardize index column naming via `_index_name(suffix)` and remove hardcoded names. > - Maintain join verb mapping and join semantics while reorganizing logic. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 74ae0a3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? as titled, does some refractoring to override joins in the future <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Refactors join execution to split preprocessing/postprocessing, encapsulate helper logic as class methods, and standardize index column handling. > > - **Join execution refactor**: > - Introduce `_DatasetPreprocessingResult` for splitting tables into `supported_projection` and `unsupported_projection`. > - Add `_preprocess` and `_postprocess` flow in `finalize()` to handle supported-column joins and restore unsupported columns. > - Convert helper utilities to instance methods: `_split_unsupported_columns`, `_append_index_column`, `_add_back_unsupported_columns`, `_is_pa_join_not_supported`. > - Standardize index column naming via `_index_name(suffix)` and remove hardcoded names. > - Maintain join verb mapping and join semantics while reorganizing logic. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 74ae0a3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? as titled, does some refractoring to override joins in the future <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Refactors join execution to split preprocessing/postprocessing, encapsulate helper logic as class methods, and standardize index column handling. > > - **Join execution refactor**: > - Introduce `_DatasetPreprocessingResult` for splitting tables into `supported_projection` and `unsupported_projection`. > - Add `_preprocess` and `_postprocess` flow in `finalize()` to handle supported-column joins and restore unsupported columns. > - Convert helper utilities to instance methods: `_split_unsupported_columns`, `_append_index_column`, `_add_back_unsupported_columns`, `_is_pa_join_not_supported`. > - Standardize index column naming via `_index_name(suffix)` and remove hardcoded names. > - Maintain join verb mapping and join semantics while reorganizing logic. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 74ae0a3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Signed-off-by: iamjustinhsu <jhsu@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? as titled, does some refractoring to override joins in the future <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Refactors join execution to split preprocessing/postprocessing, encapsulate helper logic as class methods, and standardize index column handling. > > - **Join execution refactor**: > - Introduce `_DatasetPreprocessingResult` for splitting tables into `supported_projection` and `unsupported_projection`. > - Add `_preprocess` and `_postprocess` flow in `finalize()` to handle supported-column joins and restore unsupported columns. > - Convert helper utilities to instance methods: `_split_unsupported_columns`, `_append_index_column`, `_add_back_unsupported_columns`, `_is_pa_join_not_supported`. > - Standardize index column naming via `_index_name(suffix)` and remove hardcoded names. > - Maintain join verb mapping and join semantics while reorganizing logic. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 74ae0a3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Signed-off-by: iamjustinhsu <jhsu@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
as titled, does some refractoring to override joins in the future
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.Note
Refactors join execution to split preprocessing/postprocessing, encapsulate helper logic as class methods, and standardize index column handling.
_DatasetPreprocessingResultfor splitting tables intosupported_projectionandunsupported_projection._preprocessand_postprocessflow infinalize()to handle supported-column joins and restore unsupported columns._split_unsupported_columns,_append_index_column,_add_back_unsupported_columns,_is_pa_join_not_supported._index_name(suffix)and remove hardcoded names.Written by Cursor Bugbot for commit 74ae0a3. This will update automatically on new commits. Configure here.