[core] Fix cpp api mac breakage from #56514#56915
Merged
edoakes merged 10 commits intoray-project:masterfrom Sep 29, 2025
Merged
[core] Fix cpp api mac breakage from #56514#56915edoakes merged 10 commits intoray-project:masterfrom
edoakes merged 10 commits intoray-project:masterfrom
Conversation
22b22e6 to
d4910a1
Compare
d4910a1 to
3ac5127
Compare
Signed-off-by: dayshah <dhyey2019@gmail.com>
de8cbda to
d5ba081
Compare
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
edoakes
reviewed
Sep 29, 2025
| @@ -0,0 +1,37 @@ | |||
| // Copyright 2017 The Ray Authors. | |||
dstrodtman
pushed a commit
to dstrodtman/ray
that referenced
this pull request
Oct 6, 2025
…6915) https://buildkite.com/ray-project/postmerge-macos/builds/8257#01997de0-1e13-4954-a370-6255f650ca17 mac c++ / java tests broke after ray-project#56514. Fixing by reverting to have tag_defs.cc define the vars in a separate file and not just in the header. Why does this fix it - I have no idea... for some reason the c++ api dynamic linking madness doesn't like the inlined vars on the mac build specifically??? --------- Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
joshkodi
pushed a commit
to joshkodi/ray
that referenced
this pull request
Oct 13, 2025
…6915) https://buildkite.com/ray-project/postmerge-macos/builds/8257#01997de0-1e13-4954-a370-6255f650ca17 mac c++ / java tests broke after ray-project#56514. Fixing by reverting to have tag_defs.cc define the vars in a separate file and not just in the header. Why does this fix it - I have no idea... for some reason the c++ api dynamic linking madness doesn't like the inlined vars on the mac build specifically??? --------- Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Josh Kodi <joshkodi@gmail.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
…6915) https://buildkite.com/ray-project/postmerge-macos/builds/8257#01997de0-1e13-4954-a370-6255f650ca17 mac c++ / java tests broke after ray-project#56514. Fixing by reverting to have tag_defs.cc define the vars in a separate file and not just in the header. Why does this fix it - I have no idea... for some reason the c++ api dynamic linking madness doesn't like the inlined vars on the mac build specifically??? --------- Signed-off-by: dayshah <dhyey2019@gmail.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…6915) https://buildkite.com/ray-project/postmerge-macos/builds/8257#01997de0-1e13-4954-a370-6255f650ca17 mac c++ / java tests broke after ray-project#56514. Fixing by reverting to have tag_defs.cc define the vars in a separate file and not just in the header. Why does this fix it - I have no idea... for some reason the c++ api dynamic linking madness doesn't like the inlined vars on the mac build specifically??? --------- Signed-off-by: dayshah <dhyey2019@gmail.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…6915) https://buildkite.com/ray-project/postmerge-macos/builds/8257#01997de0-1e13-4954-a370-6255f650ca17 mac c++ / java tests broke after ray-project#56514. Fixing by reverting to have tag_defs.cc define the vars in a separate file and not just in the header. Why does this fix it - I have no idea... for some reason the c++ api dynamic linking madness doesn't like the inlined vars on the mac build specifically??? --------- Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…6915) https://buildkite.com/ray-project/postmerge-macos/builds/8257#01997de0-1e13-4954-a370-6255f650ca17 mac c++ / java tests broke after ray-project#56514. Fixing by reverting to have tag_defs.cc define the vars in a separate file and not just in the header. Why does this fix it - I have no idea... for some reason the c++ api dynamic linking madness doesn't like the inlined vars on the mac build specifically??? --------- Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
https://buildkite.com/ray-project/postmerge-macos/builds/8257#01997de0-1e13-4954-a370-6255f650ca17
mac c++ / java tests broke after #56514.
Fixing by reverting to have tag_defs.cc define the vars in a separate file and not just in the header.
Why does this fix it - I have no idea... for some reason the c++ api dynamic linking madness doesn't like the inlined vars on the mac build specifically???
Note
Moves stats tag key definitions to a new implementation file and replaces object-store tag keys with string literals, updating metric definitions/usages and BUILD.
TagKeyTypedefinitions fromtag_defs.hto newtag_defs.cc(nowexternin header); convertLocationKeyandObjectStateKeytoconstexpr std::string_view.object_store_memorytags inmetric_defs.ccto use ("Location", "ObjectState").LocalObjectManager::RecordMetricsto recordSTATS_object_store_memorywith{{stats::LocationKey, "SPILLED"}}.tag_defs.cctosrcsof//src/ray/stats:tag_defsinBUILD.bazel.Written by Cursor Bugbot for commit 53cb359. This will update automatically on new commits. Configure here.