Revising test_jax_trainer flaky test#56854
Merged
matthewdeng merged 8 commits intoray-project:masterfrom Oct 3, 2025
Merged
Conversation
Signed-off-by: JasonLi1909 <jasli1909@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a flaky test in test_jax_trainer.py by removing a runtime_env that was being used to set up the JAX environment in test fixtures. The removed runtime_env was installing jax via pip and forcing JAX_PLATFORMS to cpu, which is a likely source of flakiness and incorrect for tests simulating TPU environments. The change simplifies the test setup and relies on a pre-configured test environment, which is a good practice for improving test stability. The changes are correct and well-justified.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: JasonLi1909 <jasli1909@gmail.com>
Signed-off-by: JasonLi1909 <jasli1909@gmail.com>
Signed-off-by: JasonLi1909 <jasli1909@gmail.com>
Signed-off-by: JasonLi1909 <jasli1909@gmail.com>
Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com>
matthewdeng
approved these changes
Oct 3, 2025
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
Revisiting #56548 as test continues to be flaky on CI **Solution**: The previous attempt to deflake this test still used a `pip install jax` via the `ray.init` runtime_env args. Hence, the pip install related error persisted. This PR instead adds `jax` and `jaxlib` as a dependency of CI train tests, avoiding the need to `pip install jax` via the runtime_env. --------- Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
eicherseiji
pushed a commit
to eicherseiji/ray
that referenced
this pull request
Oct 6, 2025
Revisiting ray-project#56548 as test continues to be flaky on CI **Solution**: The previous attempt to deflake this test still used a `pip install jax` via the `ray.init` runtime_env args. Hence, the pip install related error persisted. This PR instead adds `jax` and `jaxlib` as a dependency of CI train tests, avoiding the need to `pip install jax` via the runtime_env. --------- Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com> Signed-off-by: Seiji Eicher <seiji@anyscale.com>
eicherseiji
pushed a commit
to eicherseiji/ray
that referenced
this pull request
Oct 6, 2025
Revisiting ray-project#56548 as test continues to be flaky on CI **Solution**: The previous attempt to deflake this test still used a `pip install jax` via the `ray.init` runtime_env args. Hence, the pip install related error persisted. This PR instead adds `jax` and `jaxlib` as a dependency of CI train tests, avoiding the need to `pip install jax` via the runtime_env. --------- Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com>
eicherseiji
pushed a commit
to eicherseiji/ray
that referenced
this pull request
Oct 6, 2025
Revisiting ray-project#56548 as test continues to be flaky on CI **Solution**: The previous attempt to deflake this test still used a `pip install jax` via the `ray.init` runtime_env args. Hence, the pip install related error persisted. This PR instead adds `jax` and `jaxlib` as a dependency of CI train tests, avoiding the need to `pip install jax` via the runtime_env. --------- Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com>
eicherseiji
pushed a commit
to eicherseiji/ray
that referenced
this pull request
Oct 6, 2025
Revisiting ray-project#56548 as test continues to be flaky on CI **Solution**: The previous attempt to deflake this test still used a `pip install jax` via the `ray.init` runtime_env args. Hence, the pip install related error persisted. This PR instead adds `jax` and `jaxlib` as a dependency of CI train tests, avoiding the need to `pip install jax` via the runtime_env. --------- Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com>
eicherseiji
pushed a commit
to eicherseiji/ray
that referenced
this pull request
Oct 6, 2025
Revisiting ray-project#56548 as test continues to be flaky on CI **Solution**: The previous attempt to deflake this test still used a `pip install jax` via the `ray.init` runtime_env args. Hence, the pip install related error persisted. This PR instead adds `jax` and `jaxlib` as a dependency of CI train tests, avoiding the need to `pip install jax` via the runtime_env. --------- Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com>
liulehui
pushed a commit
to liulehui/ray
that referenced
this pull request
Oct 9, 2025
Revisiting ray-project#56548 as test continues to be flaky on CI **Solution**: The previous attempt to deflake this test still used a `pip install jax` via the `ray.init` runtime_env args. Hence, the pip install related error persisted. This PR instead adds `jax` and `jaxlib` as a dependency of CI train tests, avoiding the need to `pip install jax` via the runtime_env. --------- Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com>
joshkodi
pushed a commit
to joshkodi/ray
that referenced
this pull request
Oct 13, 2025
Revisiting ray-project#56548 as test continues to be flaky on CI **Solution**: The previous attempt to deflake this test still used a `pip install jax` via the `ray.init` runtime_env args. Hence, the pip install related error persisted. This PR instead adds `jax` and `jaxlib` as a dependency of CI train tests, avoiding the need to `pip install jax` via the runtime_env. --------- Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com> Signed-off-by: Josh Kodi <joshkodi@gmail.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
Revisiting ray-project#56548 as test continues to be flaky on CI **Solution**: The previous attempt to deflake this test still used a `pip install jax` via the `ray.init` runtime_env args. Hence, the pip install related error persisted. This PR instead adds `jax` and `jaxlib` as a dependency of CI train tests, avoiding the need to `pip install jax` via the runtime_env. --------- Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
Revisiting ray-project#56548 as test continues to be flaky on CI **Solution**: The previous attempt to deflake this test still used a `pip install jax` via the `ray.init` runtime_env args. Hence, the pip install related error persisted. This PR instead adds `jax` and `jaxlib` as a dependency of CI train tests, avoiding the need to `pip install jax` via the runtime_env. --------- Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
Revisiting ray-project#56548 as test continues to be flaky on CI **Solution**: The previous attempt to deflake this test still used a `pip install jax` via the `ray.init` runtime_env args. Hence, the pip install related error persisted. This PR instead adds `jax` and `jaxlib` as a dependency of CI train tests, avoiding the need to `pip install jax` via the runtime_env. --------- Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
Revisiting ray-project#56548 as test continues to be flaky on CI **Solution**: The previous attempt to deflake this test still used a `pip install jax` via the `ray.init` runtime_env args. Hence, the pip install related error persisted. This PR instead adds `jax` and `jaxlib` as a dependency of CI train tests, avoiding the need to `pip install jax` via the runtime_env. --------- Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: Jason Li <57246540+JasonLi1909@users.noreply.github.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revisiting #56548 as test continues to be flaky on CI
Solution: The previous attempt to deflake this test still used a
pip install jaxvia theray.initruntime_env args. Hence, the pip install related error persisted. This PR instead addsjaxandjaxlibas a dependency of CI train tests, avoiding the need topip install jaxvia the runtime_env.