Fix log monitor process check for process liveness#5655
Merged
robertnishihara merged 1 commit intoray-project:masterfrom Sep 7, 2019
Merged
Fix log monitor process check for process liveness#5655robertnishihara merged 1 commit intoray-project:masterfrom
robertnishihara merged 1 commit intoray-project:masterfrom
Conversation
|
Test PASSed. |
robertnishihara
approved these changes
Sep 7, 2019
Collaborator
|
This will be a bit brittle if/when we have the log/monitor track stdout/stderr for more processes, so I see this breaking again in the future. Any suggestions for how to address that? |
Contributor
Author
|
The root problem here is that worker_pid should be a pid and not a string. We could just always print the PID at the beginning of logfiles and have the raylet also do that. I created an issue here: #5657 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
#5649
Checks
scripts/format.shto lint the changes in this PR.