Skip to content

[Core][Autoscaler] Add labels to KubeRay autoscaling config#56532

Merged
jjyao merged 8 commits intoray-project:masterfrom
ryanaoleary:autoscaling-config-labels
Sep 16, 2025
Merged

[Core][Autoscaler] Add labels to KubeRay autoscaling config#56532
jjyao merged 8 commits intoray-project:masterfrom
ryanaoleary:autoscaling-config-labels

Conversation

@ryanaoleary
Copy link
Copy Markdown
Contributor

@ryanaoleary ryanaoleary commented Sep 15, 2025 •
edited
Loading

Why are these changes needed?

This PR adds a new labels field to the autoscaling config for the KubeRay autoscaler. This PR adds logic to detect labels from the worker group spec of a Ray CR. Ray node labels are specified per worker-group in KubeRay by passing them to the rayStartParams as follows:

workerGroupSpecs:
  - replicas: 0
    minReplicas: 0
    maxReplicas: 10
    groupName: a100-group
    rayStartParams:
        labels: "ray.io/availability-region=us-central2, ray.io/accelerator-type=A100"

This change is required for the Ray autoscaler to scale available node types using labels.

Related issue number

#51564

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ryanaoleary
Add labels to autoscaling config
0219fc3 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@ryanaoleary ryanaoleary requested a review from a team as a code owner September 15, 2025 11:08
@ryanaoleary
Copy link
Copy Markdown
Contributor Author

ryanaoleary commented Sep 15, 2025

cc: @MengjinYan

@ryanaoleary ryanaoleary changed the title [Autoscaler] Add labels to autoscaling config [Core][Autoscaler] Add labels to autoscaling config Sep 15, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for labels in the KubeRay autoscaler configuration by introducing a new labels field. This field is parsed from the rayStartParams of a worker group spec in the Ray CR. The implementation includes a new function for parsing these labels with error handling, and the changes are well-supported by new unit tests. My feedback focuses on making the exception handling more specific to improve code robustness.

@ryanaoleary ryanaoleary changed the title [Core][Autoscaler] Add labels to autoscaling config [Core][Autoscaler] Add labels to KubeRay autoscaling config Sep 15, 2025
@ryanaoleary @gemini-code-assist
Update python/ray/autoscaler/_private/kuberay/autoscaling_config.py
57a77f3 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
@ray-gardener ray-gardener bot added docs An issue or change related to documentation core Issues that should be addressed in Ray Core community-contribution Contributed by the community kubernetes labels Sep 15, 2025
@ryanaoleary
Remove -vv change
2e5f797 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
MengjinYan
MengjinYan reviewed Sep 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MengjinYan MengjinYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! All are nit comments.

@ryanaoleary
Fix nits
8926a9c 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@MengjinYan MengjinYan added the go add ONLY when ready to merge, run all tests label Sep 16, 2025
ryanaoleary and others added 2 commits September 16, 2025 08:55
@ryanaoleary
fix lint
84c2b18 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@MengjinYan
Merge branch 'master' into autoscaling-config-labels
e6722bd
@jjyao jjyao enabled auto-merge (squash) September 16, 2025 18:24
@github-actions github-actions bot disabled auto-merge September 16, 2025 20:09
@MengjinYan
Copy link
Copy Markdown
Contributor

MengjinYan commented Sep 16, 2025

The java test failure should be unrelated. cc: @jjyao

@jjyao jjyao merged commit f95c202 into ray-project:master Sep 16, 2025
3 of 5 checks passed
@ryanaoleary ryanaoleary mentioned this pull request Sep 16, 2025
Open
36 tasks
jmajety-dev pushed a commit to jmajety-dev/ray that referenced this pull request Sep 16, 2025
@ryanaoleary @gemini-code-assist
@MengjinYan @jjyao @jmajety-dev
[Core][Autoscaler] Add labels to KubeRay autoscaling config (ray-pr…
569ae4f 
…oject#56532)

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Mengjin Yan <mengjinyan3@gmail.com>
Co-authored-by: Jiajun Yao <jeromeyjj@gmail.com>
ZacAttack pushed a commit to ZacAttack/ray that referenced this pull request Sep 24, 2025
@ryanaoleary @gemini-code-assist
@MengjinYan @jjyao @ZacAttack
[Core][Autoscaler] Add labels to KubeRay autoscaling config (ray-pr…
a900747 
…oject#56532)

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Mengjin Yan <mengjinyan3@gmail.com>
Co-authored-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: zac <zac@anyscale.com>
marcostephan pushed a commit to marcostephan/ray that referenced this pull request Sep 24, 2025
@ryanaoleary @gemini-code-assist
@MengjinYan @jjyao @marcostephan
[Core][Autoscaler] Add labels to KubeRay autoscaling config (ray-pr…
33f7523 
…oject#56532)

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Mengjin Yan <mengjinyan3@gmail.com>
Co-authored-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Marco Stephan <marco@magic.dev>
@Future-Outlier Future-Outlier mentioned this pull request Oct 6, 2025
Open
dstrodtman pushed a commit to dstrodtman/ray that referenced this pull request Oct 6, 2025
@ryanaoleary @gemini-code-assist
@MengjinYan @jjyao @dstrodtman
[Core][Autoscaler] Add labels to KubeRay autoscaling config (ray-pr…
99bb39c 
…oject#56532)

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Mengjin Yan <mengjinyan3@gmail.com>
Co-authored-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
justinyeh1995 pushed a commit to justinyeh1995/ray that referenced this pull request Oct 20, 2025
@ryanaoleary @gemini-code-assist
@MengjinYan @jjyao @justinyeh1995
[Core][Autoscaler] Add labels to KubeRay autoscaling config (ray-pr…
894f231 
…oject#56532)

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Mengjin Yan <mengjinyan3@gmail.com>
Co-authored-by: Jiajun Yao <jeromeyjj@gmail.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
@ryanaoleary @gemini-code-assist
@MengjinYan @jjyao @landscapepainter
[Core][Autoscaler] Add labels to KubeRay autoscaling config (ray-pr…
00e5aba 
…oject#56532)

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Mengjin Yan <mengjinyan3@gmail.com>
Co-authored-by: Jiajun Yao <jeromeyjj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MengjinYan MengjinYan MengjinYan approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community-contribution Contributed by the community core Issues that should be addressed in Ray Core docs An issue or change related to documentation go add ONLY when ready to merge, run all tests kubernetes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanaoleary @MengjinYan @jjyao