[Data] Set default file_extensions for read_parquet#56481
Merged
bveeramani merged 10 commits intomasterfrom Oct 28, 2025
Merged
[Data] Set default file_extensions for read_parquet#56481bveeramani merged 10 commits intomasterfrom
file_extensions for read_parquet#56481bveeramani merged 10 commits intomasterfrom
Conversation
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly updates the default file_extensions for read_parquet from None to ["parquet"], making the previously warned-about change effective. The implementation is clean, removing the now-obsolete FutureWarning logic, which simplifies the codebase. The changes are straightforward and align perfectly with the stated goal. I have no further comments.
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…56481) http://github.com/ray-project/ray/pull/50092 warned that we'd be changing the default `file_extensions` for Parquet from `None` to `[parquet]`. This was the motivation: > People often have non-Parquet files in their datasets (e.g., _SUCCESS or stale files). However, the default for file_extensions is None, so read_parquet tries reading the non-Parquet files. To avoid this issue, we'll change the default file extensions to something like ["parquet"]. This PR adds a warning for that change. This PR follows up on actually changes the default. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…56481) http://github.com/ray-project/ray/pull/50092 warned that we'd be changing the default `file_extensions` for Parquet from `None` to `[parquet]`. This was the motivation: > People often have non-Parquet files in their datasets (e.g., _SUCCESS or stale files). However, the default for file_extensions is None, so read_parquet tries reading the non-Parquet files. To avoid this issue, we'll change the default file extensions to something like ["parquet"]. This PR adds a warning for that change. This PR follows up on actually changes the default. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…56481) http://github.com/ray-project/ray/pull/50092 warned that we'd be changing the default `file_extensions` for Parquet from `None` to `[parquet]`. This was the motivation: > People often have non-Parquet files in their datasets (e.g., _SUCCESS or stale files). However, the default for file_extensions is None, so read_parquet tries reading the non-Parquet files. To avoid this issue, we'll change the default file extensions to something like ["parquet"]. This PR adds a warning for that change. This PR follows up on actually changes the default. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: Future-Outlier <eric901201@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…56481) http://github.com/ray-project/ray/pull/50092 warned that we'd be changing the default `file_extensions` for Parquet from `None` to `[parquet]`. This was the motivation: > People often have non-Parquet files in their datasets (e.g., _SUCCESS or stale files). However, the default for file_extensions is None, so read_parquet tries reading the non-Parquet files. To avoid this issue, we'll change the default file extensions to something like ["parquet"]. This PR adds a warning for that change. This PR follows up on actually changes the default. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
http://github.com/ray-project/ray/pull/50092 warned that we'd be changing the default
file_extensionsfor Parquet fromNoneto[parquet]. This was the motivation:This PR follows up on actually changes the default.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.Note
Sets
read_parquetdefaultfile_extensionsto['parquet'], updates Parquet datasource accordingly, and adjusts tests/file names to use.parquet.read_parquet: defaultfile_extensionsnow['parquet'](wasNone).ParquetDatasource:_FILE_EXTENSIONS = ['parquet']and uses it as default..parquetextensions (e.g.,test_include_paths, null-first-file case).*.parquet.snappyto*.snappy.parquet, including smoke-test paths.Written by Cursor Bugbot for commit a774c4e. This will update automatically on new commits. Configure here.