Skip to content

[Data] Remove redundant check for initial size of actor pool#56440

Merged
bveeramani merged 1 commit intoray-project:masterfrom
owenowenisme:data/remove-redundant-check
Sep 15, 2025
Merged

[Data] Remove redundant check for initial size of actor pool#56440
bveeramani merged 1 commit intoray-project:masterfrom
owenowenisme:data/remove-redundant-check

Conversation

@owenowenisme
Copy link
Copy Markdown
Member

@owenowenisme owenowenisme commented Sep 11, 2025

Why are these changes needed?

The check is redundant here, since the initial_size can't be smaller than min_size (which must be bigger that 1)

Related issue number

#56370 (comment)

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@owenowenisme
remove redundant check for initial size of actor pool
6bbd6f1 
Signed-off-by: You-Cheng Lin (Owen) <mses010108@gmail.com>
@owenowenisme owenowenisme mentioned this pull request Sep 11, 2025
Merged
8 tasks
@owenowenisme owenowenisme marked this pull request as ready for review September 11, 2025 02:43
@owenowenisme owenowenisme requested a review from a team as a code owner September 11, 2025 02:43
@owenowenisme
Copy link
Copy Markdown
Member Author

owenowenisme commented Sep 11, 2025

@alexeykudinkin PTAL, Thanks!

@ray-gardener ray-gardener bot added data Ray Data-related issues community-contribution Contributed by the community labels Sep 11, 2025
@richardliaw richardliaw added the go add ONLY when ready to merge, run all tests label Sep 12, 2025
@bveeramani bveeramani merged commit fba6fe7 into ray-project:master Sep 15, 2025
5 checks passed
ZacAttack pushed a commit to ZacAttack/ray that referenced this pull request Sep 24, 2025
@owenowenisme @ZacAttack
[Data] Remove redundant check for initial size of actor pool (ray-pro…
0e3b84a 
…ject#56440)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?
The check is redundant here, since the `initial_size` can't be smaller
than `min_size` (which must be bigger that 1)
<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number
ray-project#56370 (comment)
<!-- For example: "Closes ray-project#1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: You-Cheng Lin (Owen) <mses010108@gmail.com>
Signed-off-by: zac <zac@anyscale.com>
marcostephan pushed a commit to marcostephan/ray that referenced this pull request Sep 24, 2025
@owenowenisme @marcostephan
[Data] Remove redundant check for initial size of actor pool (ray-pro…
05cc560 
…ject#56440)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?
The check is redundant here, since the `initial_size` can't be smaller
than `min_size` (which must be bigger that 1)
<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number
ray-project#56370 (comment)
<!-- For example: "Closes ray-project#1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: You-Cheng Lin (Owen) <mses010108@gmail.com>
Signed-off-by: Marco Stephan <marco@magic.dev>
dstrodtman pushed a commit that referenced this pull request Oct 6, 2025
@owenowenisme @dstrodtman
[Data] Remove redundant check for initial size of actor pool (#56440)
0426870 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?
The check is redundant here, since the `initial_size` can't be smaller
than `min_size` (which must be bigger that 1)
<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number
#56370 (comment)
<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: You-Cheng Lin (Owen) <mses010108@gmail.com>
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
justinyeh1995 pushed a commit to justinyeh1995/ray that referenced this pull request Oct 20, 2025
@owenowenisme @justinyeh1995
[Data] Remove redundant check for initial size of actor pool (ray-pro…
08c349b 
…ject#56440)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?
The check is redundant here, since the `initial_size` can't be smaller
than `min_size` (which must be bigger that 1)
<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number
ray-project#56370 (comment)
<!-- For example: "Closes ray-project#1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: You-Cheng Lin (Owen) <mses010108@gmail.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
@owenowenisme @landscapepainter
[Data] Remove redundant check for initial size of actor pool (ray-pro…
615f1a4 
…ject#56440)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?
The check is redundant here, since the `initial_size` can't be smaller
than `min_size` (which must be bigger that 1)
<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number
ray-project#56370 (comment)
<!-- For example: "Closes ray-project#1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: You-Cheng Lin (Owen) <mses010108@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvspraveen gvspraveen gvspraveen approved these changes

@bveeramani bveeramani bveeramani approved these changes

Assignees

@bveeramani bveeramani

Labels

community-contribution Contributed by the community data Ray Data-related issues go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@owenowenisme @gvspraveen @bveeramani @richardliaw