[dashboard] fix grafana dashboard generation bug#56346
Merged
can-anyscale merged 1 commit intoray-project:masterfrom Sep 9, 2025
Merged
[dashboard] fix grafana dashboard generation bug#56346can-anyscale merged 1 commit intoray-project:masterfrom
can-anyscale merged 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: eric-higgins-ai <erichiggins@applied.co>
8 tasks
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in the Grafana dashboard generation where an empty global_filters_str could lead to invalid queries. The change correctly handles this specific case. My review provides a suggestion to make the fix more robust and Pythonic by using a list comprehension. This not only addresses the reported issue but also handles other edge cases, such as filter strings containing multiple or trailing commas, further improving the code's correctness and maintainability.
alanwguo
approved these changes
Sep 8, 2025
Contributor
|
thanks! |
can-anyscale
approved these changes
Sep 9, 2025
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Sep 10, 2025
If global_filters_str is empty then some queries in the dashboard contain ,, in their filters, which is invalid. Signed-off-by: eric-higgins-ai <erichiggins@applied.co>
ZacAttack
pushed a commit
to ZacAttack/ray
that referenced
this pull request
Sep 24, 2025
If global_filters_str is empty then some queries in the dashboard contain ,, in their filters, which is invalid. Signed-off-by: eric-higgins-ai <erichiggins@applied.co> Signed-off-by: zac <zac@anyscale.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
If global_filters_str is empty then some queries in the dashboard contain ,, in their filters, which is invalid. Signed-off-by: eric-higgins-ai <erichiggins@applied.co> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
If global_filters_str is empty then some queries in the dashboard contain ,, in their filters, which is invalid. Signed-off-by: eric-higgins-ai <erichiggins@applied.co>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
If global_filters_str is empty then some queries in the dashboard contain ,, in their filters, which is invalid. Signed-off-by: eric-higgins-ai <erichiggins@applied.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
If
global_filters_stris empty then some queries in the dashboard contain,,in their filters, which is invalid.Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.