[core] Delete unnecessary plasma.cc + macro#56308
Merged
dayshah merged 3 commits intoray-project:masterfrom Sep 7, 2025
Merged
[core] Delete unnecessary plasma.cc + macro#56308dayshah merged 3 commits intoray-project:masterfrom
dayshah merged 3 commits intoray-project:masterfrom
Conversation
Signed-off-by: dayshah <dhyey2019@gmail.com>
dayshah
commented
Sep 7, 2025
| public: | ||
| explicit LocalObject(Allocation allocation); | ||
| explicit LocalObject(Allocation allocation) | ||
| : allocation_(std::move(allocation)), ref_count_(0) {} |
Contributor
Author
There was a problem hiding this comment.
this was the only thing in plasma.cc...
jjyao
approved these changes
Sep 7, 2025
sampan-s-nayak
pushed a commit
to sampan-s-nayak/ray
that referenced
this pull request
Sep 8, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: sampan <sampan@anyscale.com>
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
wyhong3103
pushed a commit
to wyhong3103/ray
that referenced
this pull request
Sep 12, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: yenhong.wong <yenhong.wong@grabtaxi.com>
ZacAttack
pushed a commit
to ZacAttack/ray
that referenced
this pull request
Sep 24, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: zac <zac@anyscale.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
plasma.cc only contained one implementation from common.h, it doesn't need to exist. The RAY_DISALLOW_COPY_AND_ASSIGN is also overkill as a macro.