Conversation
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request upgrades boto3 and its related dependencies across several requirement files. The changes are mostly straightforward version bumps. I've found one potential issue with the version specifier for botocore in cloud-requirements.txt. It is too loose and could lead to installing an incompatible version. My suggestion aims to tighten this requirement to match the dependency of boto3, ensuring build reproducibility and preventing potential runtime errors.
| boto3>=1.26.76 | ||
| botocore>=1.19.52 | ||
| boto3==1.28.17 | ||
| botocore>=1.31.0 |
There was a problem hiding this comment.
The boto3==1.28.17 package has a dependency on botocore<1.32.0,>=1.31.17. The current version specifier botocore>=1.31.0 is too loose and could allow installation of an incompatible botocore version (e.g., 1.31.0 through 1.31.16). To ensure compatibility and prevent potential runtime issues, it's best to specify the full compatible range for botocore.
botocore>=1.31.17,<1.32.0
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
aslonnie
left a comment
There was a problem hiding this comment.
lgtm. not sure if this bump is high enough, but let's give it a try.
upgrading boto3 --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com> Signed-off-by: sampan <sampan@anyscale.com>
upgrading boto3 --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
upgrading boto3 --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com> Signed-off-by: yenhong.wong <yenhong.wong@grabtaxi.com>
upgrading boto3 --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com> Signed-off-by: zac <zac@anyscale.com>
upgrading boto3 --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
upgrading boto3 --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
upgrading boto3 --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
upgrading boto3