[lint] change API annotations and policy check triggers#56289
[lint] change API annotations and policy check triggers#56289
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Buildkite CI configuration to restrict when certain lint jobs run. By replacing the always tag with a specific list of Python-related component tags, these jobs will now only be triggered by relevant changes, improving CI efficiency. My review includes a suggestion to further improve the maintainability of this new tagging approach.
| - python | ||
| - dashboard | ||
| - ray_client | ||
| - data | ||
| - serve | ||
| - ml | ||
| - tune | ||
| - train | ||
| - llm | ||
| - rllib | ||
| - rllib_gpu | ||
| - doc |
There was a problem hiding this comment.
This list of tags is quite long and may require maintenance as new Python components are added to the repository. To improve maintainability, consider introducing a more generic tag, for example python-lint, that would be emitted for changes in any of the Python-related components.
The logic for this would reside in ci/pipeline/determine_tests_to_run.py (and its configuration), centralizing the component-to-tag mapping. This would avoid the need to update this YAML file when new components are added.
With such a change, this step's tags could be simplified to:
tags:
- oss
- python-lint| - oss | ||
| - lint | ||
| - always | ||
| - python |
There was a problem hiding this comment.
lint.sh also contains clang format which is c++
There was a problem hiding this comment.
this one is only running api_annotations and api_policy_check, which are slow as they are building the docs (and the wheel) from source.
the clang_format one is the job at line 3, and it is always running as it is rather light weight
so that it is limited ot python related changes, rather than all changes. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
f173eb2 to
a2a1ca7
Compare
…56289) so that they are limited ot python related changes, rather than all changes. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: sampan <sampan@anyscale.com>
…56289) so that they are limited ot python related changes, rather than all changes. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
…56289) so that they are limited ot python related changes, rather than all changes. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: yenhong.wong <yenhong.wong@grabtaxi.com>
…56289) so that they are limited ot python related changes, rather than all changes. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: zac <zac@anyscale.com>
so that they are limited ot python related changes, rather than all changes. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
…56289) so that they are limited ot python related changes, rather than all changes. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
…56289) so that they are limited ot python related changes, rather than all changes. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
so that they are limited ot python related changes, rather than all changes.