[core] Fix error handling for plasma put errors#56070
Merged
edoakes merged 5 commits intoray-project:masterfrom Sep 9, 2025
Merged
[core] Fix error handling for plasma put errors#56070edoakes merged 5 commits intoray-project:masterfrom
edoakes merged 5 commits intoray-project:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves error handling for plasma put errors by centralizing status-to-error-type mapping and ensuring errors are propagated correctly instead of being logged and forgotten. The changes are logical and enhance robustness. I've suggested a small refactoring to reduce code duplication, but overall the changes look good.
dayshah
reviewed
Aug 29, 2025
00f2cd2 to
3d5dd29
Compare
dayshah
reviewed
Sep 4, 2025
89b79c2 to
96efc56
Compare
dayshah
reviewed
Sep 5, 2025
Contributor
There was a problem hiding this comment.
@jjyao @edoakes @israbbani I don't have any good ideas on this but we have store_in_plasma_ids so that on reconstruction attempts we can put objects or failures back into plasma because getters expect the object to be in plasma. But if we fail to put in plasma for the 3 status reasons, we're kind of putting those getters into a state where they could be waiting forever. Open to ideas on a simple solution for this.
I think at least for obj store full we should retry until we can, like it should hit fallback...
9bbc064 to
8daebfa
Compare
dayshah
reviewed
Sep 8, 2025
8daebfa to
7c0ae9b
Compare
dayshah
approved these changes
Sep 9, 2025
| in_memory_store_.Put(error, dynamic_return_id); | ||
| } | ||
| } else { | ||
| in_memory_store_.Put(error, dynamic_return_id); |
Contributor
There was a problem hiding this comment.
did this else exist before your original pr?
Contributor
Author
There was a problem hiding this comment.
Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
…ry on all errs Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
7c0ae9b to
831821a
Compare
ZacAttack
pushed a commit
to ZacAttack/ray
that referenced
this pull request
Sep 24, 2025
## Why are these changes needed? Followup to ray-project#55367 (review) - map Status -> ErrorType via MapStatusToErrorType (IOError->LOCAL_RAYLET_DIED, ObjectStoreFull/Transient->OUT_OF_MEMORY, OutOfDisk->OUT_OF_DISK_ERROR; default->WORKER_DIED). - no longer log‑and‑forget on any HandleTaskReturn error. - For streaming generator returns we now always put the error into the in‑memory store first (unblocks waiters) and only then best‑effort put to plasma; failures there are just warnings. --------- Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com> Signed-off-by: zac <zac@anyscale.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
## Why are these changes needed? Followup to #55367 (review) - map Status -> ErrorType via MapStatusToErrorType (IOError->LOCAL_RAYLET_DIED, ObjectStoreFull/Transient->OUT_OF_MEMORY, OutOfDisk->OUT_OF_DISK_ERROR; default->WORKER_DIED). - no longer log‑and‑forget on any HandleTaskReturn error. - For streaming generator returns we now always put the error into the in‑memory store first (unblocks waiters) and only then best‑effort put to plasma; failures there are just warnings. --------- Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
## Why are these changes needed? Followup to ray-project#55367 (review) - map Status -> ErrorType via MapStatusToErrorType (IOError->LOCAL_RAYLET_DIED, ObjectStoreFull/Transient->OUT_OF_MEMORY, OutOfDisk->OUT_OF_DISK_ERROR; default->WORKER_DIED). - no longer log‑and‑forget on any HandleTaskReturn error. - For streaming generator returns we now always put the error into the in‑memory store first (unblocks waiters) and only then best‑effort put to plasma; failures there are just warnings. --------- Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
## Why are these changes needed? Followup to ray-project#55367 (review) - map Status -> ErrorType via MapStatusToErrorType (IOError->LOCAL_RAYLET_DIED, ObjectStoreFull/Transient->OUT_OF_MEMORY, OutOfDisk->OUT_OF_DISK_ERROR; default->WORKER_DIED). - no longer log‑and‑forget on any HandleTaskReturn error. - For streaming generator returns we now always put the error into the in‑memory store first (unblocks waiters) and only then best‑effort put to plasma; failures there are just warnings. --------- Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Followup to #55367 (review)