[core] Split gcs_actor_manager out from gcs_server_lib#56049
Merged
edoakes merged 133 commits intoray-project:masterfrom Aug 28, 2025
Merged
[core] Split gcs_actor_manager out from gcs_server_lib#56049edoakes merged 133 commits intoray-project:masterfrom
gcs_actor_manager out from gcs_server_lib#56049edoakes merged 133 commits intoray-project:masterfrom
Conversation
…es/gcs-node-manager-target
…es/gcs-resource-manager
…es/gcs-resource-manager
…es/node-manager-gcs-server
…es/gcs-actor-scheduler
…es/gcs-actor-scheduler
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a significant refactoring that decouples the GCS actor manager and scheduler from the main GCS server library. It introduces a new ActorInfoGcsServiceHandler interface and moves the gRPC service implementation for actor info into its own set of files under src/ray/gcs/gcs_server/. This greatly improves modularity and code organization. The changes to the BUILD files and test files are consistent with this refactoring. Overall, this is a high-quality refactoring. I've found one critical issue that will prevent compilation and one medium-severity suggestion to improve test maintainability.
gcs_actor_manager out from gcs_server_lib
…es/gcs-actor-manager
…es/gcs-actor-manager
…es/gcs-actor-manager
ZacAttack
approved these changes
Aug 28, 2025
tohtana
pushed a commit
to tohtana/ray
that referenced
this pull request
Aug 29, 2025
…ct#56049) Stacked on: ray-project#56002 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
tohtana
pushed a commit
to tohtana/ray
that referenced
this pull request
Aug 29, 2025
…ct#56049) Stacked on: ray-project#56002 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
gangsf
pushed a commit
to gangsf/ray
that referenced
this pull request
Sep 2, 2025
…ct#56049) Stacked on: ray-project#56002 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Gang Zhao <gang@gang-JQ62HD2C37.local>
sampan-s-nayak
pushed a commit
to sampan-s-nayak/ray
that referenced
this pull request
Sep 8, 2025
…ct#56049) Stacked on: ray-project#56002 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: sampan <sampan@anyscale.com>
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
…ct#56049) Stacked on: ray-project#56002 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
wyhong3103
pushed a commit
to wyhong3103/ray
that referenced
this pull request
Sep 12, 2025
…ct#56049) Stacked on: ray-project#56002 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: yenhong.wong <yenhong.wong@grabtaxi.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
Stacked on: #56002 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…ct#56049) Stacked on: ray-project#56002 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on: #56002