Skip to content

[core] Split gcs_placement_group_scheduler out from gcs_server_lib#55955

Merged
edoakes merged 102 commits intoray-project:masterfrom
edoakes:eoakes/placement-group-scheduler
Aug 28, 2025
Merged

[core] Split gcs_placement_group_scheduler out from gcs_server_lib#55955
edoakes merged 102 commits intoray-project:masterfrom
edoakes:eoakes/placement-group-scheduler

Conversation

@edoakes
Copy link
Copy Markdown
Collaborator

@edoakes edoakes commented Aug 26, 2025

Involved splitting GcsPlacementGroup into its own file to break circular dependency.

Also eliminated gcs_server_test_util.h by:

  1. Updating the global fakes with the implementation that was defined in the file.
  2. Moving other utilities into the single file that depended on them.

edoakes added 30 commits August 21, 2025 10:22
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@ray-gardener ray-gardener bot added the core Issues that should be addressed in Ray Core label Aug 28, 2025
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes enabled auto-merge (squash) August 28, 2025 02:14
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@github-actions github-actions bot disabled auto-merge August 28, 2025 11:55
@edoakes edoakes enabled auto-merge (squash) August 28, 2025 11:59
@edoakes edoakes disabled auto-merge August 28, 2025 13:33
@edoakes edoakes merged commit f7ee0fc into ray-project:master Aug 28, 2025
5 of 6 checks passed
edoakes added a commit that referenced this pull request Aug 28, 2025
Same treatment as: #55955

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
tohtana pushed a commit to tohtana/ray that referenced this pull request Aug 29, 2025
ray-project#55955)

Involved splitting `GcsPlacementGroup` into its own file to break
circular dependency.

Also eliminated `gcs_server_test_util.h` by:

1. Updating the global fakes with the implementation that was defined in
the file.
2. Moving other utilities into the single file that depended on them.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
tohtana pushed a commit to tohtana/ray that referenced this pull request Aug 29, 2025
…ject#56002)

Same treatment as: ray-project#55955

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
tohtana pushed a commit to tohtana/ray that referenced this pull request Aug 29, 2025
ray-project#55955)

Involved splitting `GcsPlacementGroup` into its own file to break
circular dependency.

Also eliminated `gcs_server_test_util.h` by:

1. Updating the global fakes with the implementation that was defined in
the file.
2. Moving other utilities into the single file that depended on them.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
tohtana pushed a commit to tohtana/ray that referenced this pull request Aug 29, 2025
…ject#56002)

Same treatment as: ray-project#55955

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
gangsf pushed a commit to gangsf/ray that referenced this pull request Sep 2, 2025
ray-project#55955)

Involved splitting `GcsPlacementGroup` into its own file to break
circular dependency.

Also eliminated `gcs_server_test_util.h` by:

1. Updating the global fakes with the implementation that was defined in
the file.
2. Moving other utilities into the single file that depended on them.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Gang Zhao <gang@gang-JQ62HD2C37.local>
gangsf pushed a commit to gangsf/ray that referenced this pull request Sep 2, 2025
…ject#56002)

Same treatment as: ray-project#55955

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Gang Zhao <gang@gang-JQ62HD2C37.local>
sampan-s-nayak pushed a commit to sampan-s-nayak/ray that referenced this pull request Sep 8, 2025
ray-project#55955)

Involved splitting `GcsPlacementGroup` into its own file to break
circular dependency.

Also eliminated `gcs_server_test_util.h` by:

1. Updating the global fakes with the implementation that was defined in
the file.
2. Moving other utilities into the single file that depended on them.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: sampan <sampan@anyscale.com>
sampan-s-nayak pushed a commit to sampan-s-nayak/ray that referenced this pull request Sep 8, 2025
…ject#56002)

Same treatment as: ray-project#55955

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: sampan <sampan@anyscale.com>
jugalshah291 pushed a commit to jugalshah291/ray_fork that referenced this pull request Sep 11, 2025
ray-project#55955)

Involved splitting `GcsPlacementGroup` into its own file to break
circular dependency.

Also eliminated `gcs_server_test_util.h` by:

1. Updating the global fakes with the implementation that was defined in
the file.
2. Moving other utilities into the single file that depended on them.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
jugalshah291 pushed a commit to jugalshah291/ray_fork that referenced this pull request Sep 11, 2025
…ject#56002)

Same treatment as: ray-project#55955

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
wyhong3103 pushed a commit to wyhong3103/ray that referenced this pull request Sep 12, 2025
ray-project#55955)

Involved splitting `GcsPlacementGroup` into its own file to break
circular dependency.

Also eliminated `gcs_server_test_util.h` by:

1. Updating the global fakes with the implementation that was defined in
the file.
2. Moving other utilities into the single file that depended on them.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: yenhong.wong <yenhong.wong@grabtaxi.com>
wyhong3103 pushed a commit to wyhong3103/ray that referenced this pull request Sep 12, 2025
…ject#56002)

Same treatment as: ray-project#55955

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: yenhong.wong <yenhong.wong@grabtaxi.com>
dstrodtman pushed a commit that referenced this pull request Oct 6, 2025
#55955)

Involved splitting `GcsPlacementGroup` into its own file to break
circular dependency.

Also eliminated `gcs_server_test_util.h` by:

1. Updating the global fakes with the implementation that was defined in
the file.
2. Moving other utilities into the single file that depended on them.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
dstrodtman pushed a commit to dstrodtman/ray that referenced this pull request Oct 6, 2025
…ject#56002)

Same treatment as: ray-project#55955

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
ray-project#55955)

Involved splitting `GcsPlacementGroup` into its own file to break
circular dependency.

Also eliminated `gcs_server_test_util.h` by:

1. Updating the global fakes with the implementation that was defined in
the file.
2. Moving other utilities into the single file that depended on them.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
…ject#56002)

Same treatment as: ray-project#55955

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants