[train] add usage tag key for JaxTrainer#55887
Merged
matthewdeng merged 1 commit intoray-project:masterfrom Aug 25, 2025
Merged
[train] add usage tag key for JaxTrainer#55887matthewdeng merged 1 commit intoray-project:masterfrom
matthewdeng merged 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: Matthew Deng <matt@anyscale.com>
liulehui
approved these changes
Aug 25, 2025
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds JaxTrainer to the list of V2 trainers for usage statistics collection. The change itself is correct, but it's missing corresponding test coverage. I've added a comment to suggest adding a test case for the new trainer to ensure its usage is tracked correctly.
|
|
||
| TRAIN_V2_TRAINERS = { | ||
| "DataParallelTrainer", | ||
| "JaxTrainer", |
Contributor
There was a problem hiding this comment.
While adding JaxTrainer here is correct for usage tracking, the corresponding test coverage is missing. Please update the test_tag_train_entrypoint test in python/ray/air/tests/test_air_usage.py to include JaxTrainer. This will ensure that usage stats for this new trainer are correctly reported and prevent future regressions.
For example:
# python/ray/air/tests/test_air_usage.py
# ...
from ray.train.v2.lightgbm.lightgbm_trainer import LightGBMTrainer
from ray.train.v2.jax.jax_trainer import JaxTrainer
# ...
trainer_classes = [
TorchTrainer,
TensorflowTrainer,
XGBoostTrainer,
LightGBMTrainer,
JaxTrainer,
]
# ...
edoakes
approved these changes
Aug 25, 2025
liulehui
pushed a commit
to liulehui/ray
that referenced
this pull request
Aug 26, 2025
Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: Lehui Liu <lehui@anyscale.com>
tohtana
pushed a commit
to tohtana/ray
that referenced
this pull request
Aug 29, 2025
Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
tohtana
pushed a commit
to tohtana/ray
that referenced
this pull request
Aug 29, 2025
Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
Signed-off-by: Matthew Deng <matt@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.