[Data] Make _hash_partition a separate function#55759
Merged
alexeykudinkin merged 1 commit intoray-project:masterfrom Aug 20, 2025
Merged
Conversation
Signed-off-by: Goutam V <goutam@anyscale.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the hash partitioning logic into a separate _hash_partition function for better readability and maintainability. The change is clean and improves the code. I have one minor suggestion to remove a misleading comment from the newly created function.
alexeykudinkin
approved these changes
Aug 19, 2025
dioptre
pushed a commit
to sourcetable/ray
that referenced
this pull request
Aug 20, 2025
Signed-off-by: Andrew Grosser <dioptre@gmail.com>
alimaazamat
pushed a commit
to alimaazamat/ray
that referenced
this pull request
Aug 21, 2025
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
A tiny clean up, make the hash partitioning phase a separate function for readability.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.