Skip to content

[Data] Cleaning up ExecutionResources#54694

Merged
alexeykudinkin merged 11 commits intoray-project:masterfrom
alexeykudinkin:ak/exc-opts-fix
Aug 4, 2025
Merged

[Data] Cleaning up ExecutionResources#54694
alexeykudinkin merged 11 commits intoray-project:masterfrom
alexeykudinkin:ak/exc-opts-fix

Conversation

@alexeykudinkin
Copy link
Copy Markdown
Contributor

@alexeykudinkin alexeykudinkin commented Jul 17, 2025

Why are these changes needed?

Cleaning up ExecutionResources:

  1. To make them immutable
  2. Fix 0s/nulls handling
  3. Properly round them to 1e-5 (max resource quantization in Ray)

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@alexeykudinkin alexeykudinkin requested a review from a team as a code owner July 17, 2025 01:20
@alexeykudinkin alexeykudinkin added the go add ONLY when ready to merge, run all tests label Jul 17, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @alexeykudinkin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the ExecutionResources class within Ray Data to improve its robustness and predictability. The primary goals are to make ExecutionResources objects effectively immutable, standardize the handling of zero and null resource values, and ensure all resource quantities are properly rounded to align with Ray Core's resource quantization.

Highlights

  • Enforced Immutability: The direct setters for resource properties (cpu, gpu, memory, object_store_memory) have been deprecated. Instead, the copy() method has been enhanced to allow creating a new ExecutionResources instance with specific resource overrides, promoting a functional, immutable pattern for resource management.
  • Standardized Resource Initialization and Null Handling: The ExecutionResources constructor and from_resource_dict method now consistently initialize resource attributes to 0.0 (or rounded values) if not explicitly provided, eliminating the need for the default_to_inf flag and simplifying resource interpretation.
  • Precise Resource Quantization: New helper functions safe_round and safe_or have been introduced to ensure that all resource values are rounded to the 5th decimal place, matching Ray Core's internal resource allocation granularity, and to provide robust handling of None values.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the ExecutionResources class by making it immutable, fixing the handling of zeros and nulls, and adding proper rounding. The changes are well-structured and the new helper functions are a good addition. To maintain consistency, the deprecated setters should be consistent with the constructor's rounding logic.

python/ray/data/_internal/execution/interfaces/execution_options.py Outdated
Comment on lines 86 to 87
def cpu(self, value: float):
self._cpu = value
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider rounding the input value in the deprecated setter for consistency with the constructor.[^1] The constructor rounds resource values to the 5th decimal digit, but the setter does not, which could lead to unexpected behavior if the setter is used.

self._cpu = safe_round(value, 5) or 0.0

python/ray/data/_internal/execution/interfaces/execution_options.py Outdated
Comment on lines 95 to 96
def gpu(self, value: float):
self._gpu = value
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider rounding the input value in the deprecated setter for consistency with the constructor.[^1] The constructor rounds resource values to the 5th decimal digit, but the setter does not, which could lead to unexpected behavior if the setter is used.

self._gpu = safe_round(value, 5) or 0.0

raulchen
raulchen reviewed Jul 17, 2025
View reviewed changes
python/ray/data/_internal/execution/interfaces/execution_options.py
elif math.isinf(value):
return value
else:
return round(value, ndigits)
Copy link
Copy Markdown
Contributor

@raulchen raulchen Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the the behavior when ndigit is None? Can you add a comment?

Copy link
Copy Markdown
Contributor Author

@alexeykudinkin alexeykudinkin Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ndigits=None is Python's default

https://docs.python.org/3/library/functions.html#round

python/ray/data/_internal/execution/interfaces/execution_options.py Outdated
return self._gpu

@gpu.setter
@deprecated("Use copy() instead")
Copy link
Copy Markdown
Contributor

@raulchen raulchen Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Can you also update existing use cases?
If too many, we can just update the ones on the critical path first.

Copy link
Copy Markdown
Contributor Author

@alexeykudinkin alexeykudinkin Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was doing that in separate PR, but fair enough

@alexeykudinkin alexeykudinkin requested review from a team as code owners July 29, 2025 01:02
@alexeykudinkin
Revisited ExecutionResources to
71f8580 
 - Make them immutable
 - Properly round up resources
 - Fix 0s/nulls handling

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
lint
1d1554e 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
Avoid modifying objects in-place
3370854 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
Cleaning up tests
7fa5565 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
Defer fallback to actual access
866f8d3 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
Fixed remaining uses
e9c0879 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
Updated tests
5858dd2 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
lint
b2e270f 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
lint
dd90b99 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
Updated fixture
4797783 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin alexeykudinkin enabled auto-merge (squash) August 2, 2025 02:04
@github-actions github-actions bot disabled auto-merge August 2, 2025 02:04
@alexeykudinkin
Tidying up
a164e15 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin alexeykudinkin enabled auto-merge (squash) August 4, 2025 06:12
angelinalg
angelinalg approved these changes Aug 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@alexeykudinkin alexeykudinkin merged commit 6b703a8 into ray-project:master Aug 4, 2025
6 checks passed
elliot-barn pushed a commit that referenced this pull request Aug 4, 2025
@alexeykudinkin @elliot-barn
[Data] Cleaning up ExecutionResources (#54694)
06d9fe4 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

Cleaning up `ExecutionResources`:

1. To make them immutable
2. Fix 0s/nulls handling
3. Properly round them to 1e-5 (max resource quantization in Ray)

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
kamil-kaczmarek pushed a commit that referenced this pull request Aug 4, 2025
@alexeykudinkin @kamil-kaczmarek
[Data] Cleaning up ExecutionResources (#54694)
993677c 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

Cleaning up `ExecutionResources`:

1. To make them immutable
2. Fix 0s/nulls handling
3. Properly round them to 1e-5 (max resource quantization in Ray)

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
mjacar pushed a commit to mjacar/ray that referenced this pull request Aug 5, 2025
@alexeykudinkin @mjacar
[Data] Cleaning up ExecutionResources (ray-project#54694)
9ad066e 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

Cleaning up `ExecutionResources`:

1. To make them immutable
2. Fix 0s/nulls handling
3. Properly round them to 1e-5 (max resource quantization in Ray)

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Michael Acar <michael.j.acar@gmail.com>
sampan-s-nayak pushed a commit that referenced this pull request Aug 12, 2025
@alexeykudinkin
[Data] Cleaning up ExecutionResources (#54694)
19e8b3f 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

Cleaning up `ExecutionResources`:

1. To make them immutable
2. Fix 0s/nulls handling
3. Properly round them to 1e-5 (max resource quantization in Ray)

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: sampan <sampan@anyscale.com>
JackGammack added a commit to JackGammack/ray that referenced this pull request Aug 28, 2025
@JackGammack
Update performance tips documentation for new execution options resou…
3d4bd4b 
…rce limits assignment

Setting these resource limits directly no longer works in 2.49 after ray-project#54694 

Signed-off-by: Jack Gammack <49536617+JackGammack@users.noreply.github.com>
@JackGammack JackGammack mentioned this pull request Aug 28, 2025
Merged
8 tasks
alexeykudinkin pushed a commit that referenced this pull request Sep 2, 2025
@JackGammack
[docs] Update performance tips documentation for new execution option…
629e4d6 
…s resource limits assignment (#56051)

## Why are these changes needed?

The performance tips documentation for setting resource limits in
ExecutionOptions is no longer correct and gives an error when directly
setting them in 2.49 after #54694. Update the documentation to show how
to correctly set them.

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Jack Gammack <49536617+JackGammack@users.noreply.github.com>
sampan-s-nayak pushed a commit to sampan-s-nayak/ray that referenced this pull request Sep 8, 2025
@JackGammack
[docs] Update performance tips documentation for new execution option…
232e9c9 
…s resource limits assignment (ray-project#56051)

## Why are these changes needed?

The performance tips documentation for setting resource limits in
ExecutionOptions is no longer correct and gives an error when directly
setting them in 2.49 after ray-project#54694. Update the documentation to show how
to correctly set them.

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Jack Gammack <49536617+JackGammack@users.noreply.github.com>
Signed-off-by: sampan <sampan@anyscale.com>
jugalshah291 pushed a commit to jugalshah291/ray_fork that referenced this pull request Sep 11, 2025
@alexeykudinkin @jugalshah291
[Data] Cleaning up ExecutionResources (ray-project#54694)
5155ee6 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

Cleaning up `ExecutionResources`:

1. To make them immutable
2. Fix 0s/nulls handling
3. Properly round them to 1e-5 (max resource quantization in Ray)

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
jugalshah291 pushed a commit to jugalshah291/ray_fork that referenced this pull request Sep 11, 2025
@JackGammack @jugalshah291
[docs] Update performance tips documentation for new execution option…
4d6fc0c 
…s resource limits assignment (ray-project#56051)

## Why are these changes needed?

The performance tips documentation for setting resource limits in
ExecutionOptions is no longer correct and gives an error when directly
setting them in 2.49 after ray-project#54694. Update the documentation to show how
to correctly set them.

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Jack Gammack <49536617+JackGammack@users.noreply.github.com>
Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
wyhong3103 pushed a commit to wyhong3103/ray that referenced this pull request Sep 12, 2025
@JackGammack
[docs] Update performance tips documentation for new execution option…
d507740 
…s resource limits assignment (ray-project#56051)

## Why are these changes needed?

The performance tips documentation for setting resource limits in
ExecutionOptions is no longer correct and gives an error when directly
setting them in 2.49 after ray-project#54694. Update the documentation to show how
to correctly set them.

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Jack Gammack <49536617+JackGammack@users.noreply.github.com>
Signed-off-by: yenhong.wong <yenhong.wong@grabtaxi.com>
dstrodtman pushed a commit that referenced this pull request Oct 6, 2025
@alexeykudinkin @dstrodtman
[Data] Cleaning up ExecutionResources (#54694)
f520812 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

Cleaning up `ExecutionResources`:

1. To make them immutable
2. Fix 0s/nulls handling
3. Properly round them to 1e-5 (max resource quantization in Ray)

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
dstrodtman pushed a commit to dstrodtman/ray that referenced this pull request Oct 6, 2025
@JackGammack @dstrodtman
[docs] Update performance tips documentation for new execution option…
1d629ac 
…s resource limits assignment (ray-project#56051)

## Why are these changes needed?

The performance tips documentation for setting resource limits in
ExecutionOptions is no longer correct and gives an error when directly
setting them in 2.49 after ray-project#54694. Update the documentation to show how
to correctly set them.

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Jack Gammack <49536617+JackGammack@users.noreply.github.com>
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
@JackGammack @landscapepainter
[docs] Update performance tips documentation for new execution option…
676065c 
…s resource limits assignment (ray-project#56051)

## Why are these changes needed?

The performance tips documentation for setting resource limits in
ExecutionOptions is no longer correct and gives an error when directly
setting them in 2.49 after ray-project#54694. Update the documentation to show how
to correctly set them.

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Jack Gammack <49536617+JackGammack@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulchen raulchen raulchen approved these changes

@kamil-kaczmarek kamil-kaczmarek kamil-kaczmarek approved these changes

@angelinalg angelinalg angelinalg approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexeykudinkin @raulchen @kamil-kaczmarek @angelinalg