Skip to content

[core] fix get_max_resources_from_cluster_config#54455

Merged
raulchen merged 5 commits intoray-project:masterfrom
xinyuangui2:update-state-max-resource-function
Jul 9, 2025
Merged

[core] fix get_max_resources_from_cluster_config#54455
raulchen merged 5 commits intoray-project:masterfrom
xinyuangui2:update-state-max-resource-function

Conversation

@xinyuangui2
Copy link
Copy Markdown
Contributor

@xinyuangui2 xinyuangui2 commented Jul 9, 2025

Why are these changes needed?

get_max_resources_from_cluster_config is only returning CPU, GPU, and TPU. But users might need to check other available resources, like memory.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: xgui <xgui@anyscale.com>
Signed-off-by: xgui <xgui@anyscale.com>
Copy link
Copy Markdown
Contributor

@alexeykudinkin alexeykudinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments, please address before landing

Signed-off-by: xgui <xgui@anyscale.com>
@alexeykudinkin alexeykudinkin enabled auto-merge (squash) July 9, 2025 20:48
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 9, 2025
@alexeykudinkin alexeykudinkin disabled auto-merge July 9, 2025 20:48
Signed-off-by: xgui <xgui@anyscale.com>
Signed-off-by: xgui <xgui@anyscale.com>
@xinyuangui2 xinyuangui2 requested a review from raulchen July 9, 2025 21:42
@raulchen raulchen enabled auto-merge (squash) July 9, 2025 21:57
@raulchen raulchen merged commit ce539b3 into ray-project:master Jul 9, 2025
6 checks passed
jugalshah291 pushed a commit to jugalshah291/ray_fork that referenced this pull request Sep 11, 2025
## Why are these changes needed?

`get_max_resources_from_cluster_config` is only returning `CPU`, `GPU`,
and `TPU`. But users might need to check other available resources, like
`memory`.

---------

Signed-off-by: xgui <xgui@anyscale.com>
Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
dstrodtman pushed a commit to dstrodtman/ray that referenced this pull request Oct 6, 2025
## Why are these changes needed?

`get_max_resources_from_cluster_config` is only returning `CPU`, `GPU`,
and `TPU`. But users might need to check other available resources, like
`memory`.

---------

Signed-off-by: xgui <xgui@anyscale.com>
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants