Add label selector observability to placement group tables and actor and task detail pages#54292
Merged
edoakes merged 4 commits intoray-project:masterfrom Jul 9, 2025
Conversation
…and task detail pages Signed-off-by: Alan Guo <aguo@anyscale.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds observability for label selectors across several UI components and updates the placement group tables to use a unified code preview component.
- Extend the
Bundletype with an optionallabel_selectorfield. - Add “Label Selector” sections in Task and Actor detail pages using
CodeDialogButtonWithPreview. - Introduce a
LabelSelectorcolumn/component in the Placement Group table.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| python/ray/dashboard/client/src/type/placementGroup.ts | Add label_selector to Bundle type. |
| python/ray/dashboard/client/src/pages/task/TaskPage.tsx | Display label selector in task details. |
| python/ray/dashboard/client/src/pages/actor/ActorDetail.tsx | Display required resources and label selector. |
| python/ray/dashboard/client/src/components/PlacementGroupTable.tsx | Add LabelSelector component and table column. |
MengjinYan
approved these changes
Jul 2, 2025
Contributor
MengjinYan
left a comment
There was a problem hiding this comment.
Thank for the quick turn-around! I'm not familiar with the UI code to review the exact change, but the change of dashboard UI looks good!
Contributor
Author
|
@MengjinYan ready to merge! |
cristianjd
approved these changes
Jul 8, 2025
Contributor
|
@edoakes Can you help to merge the PR? |
bartcheers
approved these changes
Jul 8, 2025
bartcheers
left a comment
There was a problem hiding this comment.
Looks great. Other than the waitFor vs setTimeout there's a small opportunity to DRY up undleResourceRequirements and LabelSelector since they share quite a bit of the logic, but they don't seem exactly the same so might be overdoing it.
| await user.type(input, "CREATED"); | ||
|
|
||
| // Wait for the filter to be applied | ||
| await new Promise((resolve) => setTimeout(resolve, 100)); |
There was a problem hiding this comment.
You can do something like this with testing-library instead of the timeouts, which should make the test less flaky:
await waitFor(() => {
expect(screen.queryByText("pg-987654321")).not.toBeInTheDocument();
expect(screen.queryByText("pg-555666777")).not.toBeInTheDocument();
});
There was a problem hiding this comment.
There 3 other places in this PR where you could replace setTimeout for waitFor
ccmao1130
pushed a commit
to ccmao1130/ray
that referenced
this pull request
Jul 29, 2025
…and task detail pages (ray-project#54292) Follow-up to ray-project#53423 Missed a few places in the UI. Also updates placement group tables to use the same code preview component as the actor and tasks tables. Placement group table   Actor detail  Task detail  --------- Signed-off-by: Alan Guo <aguo@anyscale.com> Signed-off-by: ChanChan Mao <chanchanmao1130@gmail.com>
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
…and task detail pages (ray-project#54292) Follow-up to ray-project#53423 Missed a few places in the UI. Also updates placement group tables to use the same code preview component as the actor and tasks tables. Placement group table   Actor detail  Task detail  --------- Signed-off-by: Alan Guo <aguo@anyscale.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
dstrodtman
pushed a commit
to dstrodtman/ray
that referenced
this pull request
Oct 6, 2025
…and task detail pages (ray-project#54292) Follow-up to ray-project#53423 Missed a few places in the UI. Also updates placement group tables to use the same code preview component as the actor and tasks tables. Placement group table   Actor detail  Task detail  --------- Signed-off-by: Alan Guo <aguo@anyscale.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Follow-up to #53423
Missed a few places in the UI.
Also updates placement group tables to use the same code preview component as the actor and tasks tables.
Placement group table
Actor detail
Task detail
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.