Skip to content

defer loading csat so gtag loads first#53968

Merged
angelinalg merged 1 commit intoray-project:masterfrom
vigneshka:vigneshka/fix-gtag
Jun 20, 2025
Merged

defer loading csat so gtag loads first#53968
angelinalg merged 1 commit intoray-project:masterfrom
vigneshka:vigneshka/fix-gtag

Conversation

@vigneshka
Copy link
Copy Markdown
Contributor

@vigneshka vigneshka commented Jun 20, 2025 •
edited
Loading

Fixes error ReferenceError: gtag is not defined

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@vigneshka
defer loading csat
ceade2c 
Signed-off-by: Vignesh Hirudayakanth <vigneshkanth@gmail.com>
@vigneshka vigneshka requested a review from a team as a code owner June 20, 2025 04:21
angelinalg
angelinalg approved these changes Jun 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@angelinalg angelinalg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@angelinalg angelinalg added the go add ONLY when ready to merge, run all tests label Jun 20, 2025
@angelinalg angelinalg enabled auto-merge (squash) June 20, 2025 04:31
@angelinalg angelinalg merged commit dd1e3cb into ray-project:master Jun 20, 2025
6 checks passed
minerharry pushed a commit to minerharry/ray that referenced this pull request Jun 27, 2025
@vigneshka @minerharry
defer loading csat so gtag loads first (ray-project#53968)
668211d
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
@vigneshka @elliot-barn
defer loading csat so gtag loads first (#53968)
27512fa 
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelinalg angelinalg angelinalg approved these changes

Assignees

No one assigned

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vigneshka @angelinalg