Skip to content

[train][template] Remove clock emoji which does not always render well#53965

Merged
justinvyu merged 1 commit intoray-project:masterfrom
TimothySeah:tseah/remove-clock
Jun 20, 2025
Merged

[train][template] Remove clock emoji which does not always render well#53965
justinvyu merged 1 commit intoray-project:masterfrom
TimothySeah:tseah/remove-clock

Conversation

@TimothySeah
Copy link
Copy Markdown
Contributor

@TimothySeah TimothySeah commented Jun 19, 2025

Example screenshot of a case where the clock emoji doesn't render:

Screenshot 2025-06-19 at 2 57 32 PM

It still looks fine in a Jupyter notebook viewer (ex: vscode):

Screenshot 2025-06-19 at 2 58 52 PM

Removing it just to be safe.

…e preview

Signed-off-by: Timothy Seah <tseah@anyscale.com>
@TimothySeah TimothySeah requested review from a team as code owners June 19, 2025 23:53
Copy link
Copy Markdown
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

Copy link
Copy Markdown
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@justinvyu justinvyu changed the title [train][template] Remove clock emoji which does not render in template preview [train][template] Remove clock emoji which does not always render well Jun 20, 2025
@justinvyu justinvyu enabled auto-merge (squash) June 20, 2025 00:11
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 20, 2025
@justinvyu justinvyu merged commit 22f619d into ray-project:master Jun 20, 2025
6 checks passed
minerharry pushed a commit to minerharry/ray that referenced this pull request Jun 27, 2025
ray-project#53965)

Signed-off-by: Timothy Seah <tseah@anyscale.com>
Co-authored-by: Timothy Seah <tseah@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
#53965)

Signed-off-by: Timothy Seah <tseah@anyscale.com>
Co-authored-by: Timothy Seah <tseah@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants