[core] Making NodeManager use ILocalTaskManager instead of TaskManager.#53961
Merged
[core] Making NodeManager use ILocalTaskManager instead of TaskManager.#53961
Conversation
This will allow unit tests of NodeManager to use a Fake implementation of LocalTaskManager where appropriate. Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
jjyao
approved these changes
Jun 19, 2025
Signed-off-by: irabbani <irabbani@anyscale.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
…r. (ray-project#53961) Signed-off-by: irabbani <irabbani@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
…r. (#53961) Signed-off-by: irabbani <irabbani@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow unit tests of NodeManager to use a Fake implementation of LocalTaskManager where appropriate.
I've created CORE-1644 as a follow-up to remove usage of NoopLocalTaskManager from the GCS which is a clear encapsulation leak.