fastapi and streaming tests use get applications api#53949
Merged
Conversation
Signed-off-by: abrar <abrar@anyscale.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates various tests for FastAPI and streaming responses to use dynamic URL retrieval via the get_application_url(s) API instead of hard-coded localhost URLs.
- Update streaming requester and response tests to use get_application_url.
- Update FastAPI and API tests to build URLs dynamically and remove trailing slashes for consistency.
- Refactor URL construction in the test utilities and adjust message processing in HTTP utilities.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| python/ray/serve/tests/test_streaming_response.py | Updated streaming tests to construct URLs using get_application_url and support multiple URLs. |
| python/ray/serve/tests/test_fastapi.py | Modified FastAPI and related endpoint tests to use dynamic URL retrieval. |
| python/ray/serve/tests/test_api.py | Revised URL assertions to remove trailing slashes for consistency. |
| python/ray/serve/_private/test_utils.py | Adjusted URL creation logic by trimming trailing slashes. |
| python/ray/serve/_private/http_util.py | Updated message handling logic for processing pickled messages in streamed responses. |
Comment on lines
+308
to
+315
| if isinstance(pickled_messages, bytes): | ||
| messages = pickle.loads(pickled_messages) | ||
| else: | ||
| messages = ( | ||
| pickled_messages | ||
| if isinstance(pickled_messages, list) | ||
| else [pickled_messages] | ||
| ) |
There was a problem hiding this comment.
Consider extracting the message processing logic (handling bytes, list, or single item) into a dedicated helper function to improve readability and maintainability.
Suggested change
| if isinstance(pickled_messages, bytes): | |
| messages = pickle.loads(pickled_messages) | |
| else: | |
| messages = ( | |
| pickled_messages | |
| if isinstance(pickled_messages, list) | |
| else [pickled_messages] | |
| ) | |
| messages = self._process_pickled_messages(pickled_messages) |
| url = f"{target.ip}:{target.port}" | ||
| else: | ||
| raise ValueError(f"Unsupported protocol: {protocol}") | ||
| url = url.rstrip("/") |
There was a problem hiding this comment.
Removing the trailing slash can affect URL consistency when route_prefix is empty; consider adding explicit unit tests to ensure expected behavior under all conditions.
Suggested change
| url = url.rstrip("/") | |
| if route_prefix: | |
| url = url.rstrip("/") |
|
|
||
| r = httpx.get(f"http://localhost:8000{expected_route_prefix}openapi.json") | ||
| url = get_application_url("HTTP") | ||
| assert expected_route_prefix.rstrip("/") in url |
There was a problem hiding this comment.
[nitpick] Using a substring assertion on the URL may lead to false positives if the URL structure changes; consider validating the complete URL format to ensure accuracy.
zcin
approved these changes
Jun 19, 2025
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
update serve fastapi and streaming tests Signed-off-by: abrar <abrar@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
update serve fastapi and streaming tests Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
snorkelopstesting3-bot
pushed a commit
to snorkel-marlin-repos/ray-project_ray_pr_53949_c2fd26f9-40af-409d-a8b3-21ac5455fce7
that referenced
this pull request
Oct 22, 2025
Original PR #53949 by abrarsheikh Original: ray-project/ray#53949
snorkelopstesting4-web
pushed a commit
to snorkel-marlin-repos/ray-project_ray_pr_53949_ae2b5fd2-b893-47c0-ae5a-e13119d93f41
that referenced
this pull request
Oct 22, 2025
Original PR #53949 by abrarsheikh Original: ray-project/ray#53949
snorkelopstesting4-web
pushed a commit
to snorkel-marlin-repos/ray-project_ray_pr_53949_a0461bee-24df-42ee-b0b3-6f86e1e7a62f
that referenced
this pull request
Oct 22, 2025
Original PR #53949 by abrarsheikh Original: ray-project/ray#53949
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.