Skip to content

[docs][Serve] Add clarification for health check and FT of serve deployments#53944

Merged
kouroshHakha merged 1 commit intoray-project:masterfrom
kouroshHakha:kh/improve-serve-ft-docs
Jun 19, 2025
Merged

[docs][Serve] Add clarification for health check and FT of serve deployments#53944
kouroshHakha merged 1 commit intoray-project:masterfrom
kouroshHakha:kh/improve-serve-ft-docs

Conversation

@kouroshHakha
Copy link
Copy Markdown
Contributor

@kouroshHakha kouroshHakha commented Jun 19, 2025

This PR adds clarifications to the fault tolerance documentation for Serve deployments.

  • Provides details on how the Serve controller handles health checks for replicas.
  • Includes notes warning against directly calling the check_health method and explaining the behavior in composable deployment graphs.

Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha kouroshHakha marked this pull request as ready for review June 19, 2025 03:13
Copilot AI review requested due to automatic review settings June 19, 2025 03:13
@kouroshHakha kouroshHakha requested review from a team as code owners June 19, 2025 03:13
@kouroshHakha kouroshHakha requested a review from zcin June 19, 2025 03:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds clarifications to the fault tolerance documentation for Serve deployments.

  • Provides details on how the Serve controller handles health checks for replicas.
  • Includes notes warning against directly calling the check_health method and explaining the behavior in composable deployment graphs.

@kouroshHakha kouroshHakha added the go add ONLY when ready to merge, run all tests label Jun 19, 2025
@kouroshHakha kouroshHakha enabled auto-merge (squash) June 19, 2025 16:36
@kouroshHakha kouroshHakha merged commit 7a182ca into ray-project:master Jun 19, 2025
6 checks passed
minerharry pushed a commit to minerharry/ray that referenced this pull request Jun 27, 2025
…oyments (ray-project#53944)

This PR adds clarifications to the fault tolerance documentation for
Serve deployments.

* Provides details on how the Serve controller handles health checks for
replicas.
* Includes notes warning against directly calling the check_health
method and explaining the behavior in composable deployment graphs.

Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
…oyments (#53944)

This PR adds clarifications to the fault tolerance documentation for
Serve deployments.

* Provides details on how the Serve controller handles health checks for
replicas.
* Includes notes warning against directly calling the check_health
method and explaining the behavior in composable deployment graphs.

Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants