[Data] Fixed BlockMetadata derivation for Read operator#53908
Merged
alexeykudinkin merged 20 commits intomasterfrom Jun 19, 2025
Merged
[Data] Fixed BlockMetadata derivation for Read operator#53908alexeykudinkin merged 20 commits intomasterfrom
BlockMetadata derivation for Read operator#53908alexeykudinkin merged 20 commits intomasterfrom
Conversation
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
bveeramani
approved these changes
Jun 18, 2025
|
|
||
| class TestMetadataProvider(ParquetMetadataProvider): | ||
| expected_num_rows = len(df1) + len(df2) | ||
| expected_byte_size = 787500 |
Member
There was a problem hiding this comment.
Where does 787500 come from? Seems kind of non-obvious at a first glance
Contributor
Author
There was a problem hiding this comment.
Total dataset byte size
| # - Passed to ReadParquet hold metadata matching actual bundle | ||
| # - Produced by ReadParquet reflects actual amount of bytes read | ||
| assert read_stats.base_name == "ReadParquet" | ||
| assert read_stats.extra_metrics["average_bytes_inputs_per_task"] < 5_000 |
Member
There was a problem hiding this comment.
Where does 5000 come from? Could you name this constant or add a comment?
Contributor
Author
There was a problem hiding this comment.
It's the task size
| ) | ||
| def test_parquet_read_meta_provider(ray_start_regular_shared, fs, data_path): | ||
| df1 = pd.DataFrame({"one": [1, 2, 3], "two": ["a", "b", "c"]}) | ||
| df1 = pd.DataFrame({"one": range(30_000), "two": ["a", "b", "c"] * 10_000}) |
Member
There was a problem hiding this comment.
What's the motivation for increasing the size the input data here?
Contributor
Author
There was a problem hiding this comment.
Otherwise the size of 2 files is much larger than the size of the task (asserted below in avg inputs size to read op)
| data_path, | ||
| filesystem=fs, | ||
| meta_provider=TestMetadataProvider(), | ||
| meta_provider=AssertingMetadataProvider(), |
Member
There was a problem hiding this comment.
FYI -- meta provider has been deprecated for many months and is slated for removal this month
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
…ect#53908) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? Currently, Planner incorrectly shapes the `BlockMetadata` for ref-bundles submitted to `Read` operator, carrying only the file-paths, while their corresponding metadata is actually being set as if these bundles were carrying actual data. That in turn inflates Object Store utilization for the Read operator, subsequently triggering back-pressure being applied to it incorrectly. ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? Currently, Planner incorrectly shapes the `BlockMetadata` for ref-bundles submitted to `Read` operator, carrying only the file-paths, while their corresponding metadata is actually being set as if these bundles were carrying actual data. That in turn inflates Object Store utilization for the Read operator, subsequently triggering back-pressure being applied to it incorrectly. ## Related issue number <!-- For example: "Closes #1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, Planner incorrectly shapes the
BlockMetadatafor ref-bundles submitted toReadoperator, carrying only the file-paths, while their corresponding metadata is actually being set as if these bundles were carrying actual data.That in turn inflates Object Store utilization for the Read operator, subsequently triggering back-pressure being applied to it incorrectly.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.