Skip to content

fix the bash code run error in notebook#53900

Merged
angelinalg merged 1 commit intomasterfrom
fix-obj-detection-template-error
Jun 19, 2025
Merged

fix the bash code run error in notebook#53900
angelinalg merged 1 commit intomasterfrom
fix-obj-detection-template-error

Conversation

@kunling-anyscale
Copy link
Copy Markdown
Contributor

@kunling-anyscale kunling-anyscale commented Jun 17, 2025

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

fix the bash code run error in notebook
74cb332 
Signed-off-by: Kunling Geng <kunling@kunling-LGW6TWQYVT.local>
Copilot AI review requested due to automatic review settings June 17, 2025 22:50
@kunling-anyscale kunling-anyscale requested a review from a team as a code owner June 17, 2025 22:50
@kunling-anyscale kunling-anyscale added go add ONLY when ready to merge, run all tests docs An issue or change related to documentation labels Jun 17, 2025
Copilot AI reviewed Jun 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a cell execution error in the object detection training notebook by ensuring the %%bash magic is the first line of the cell so it runs correctly.

  • Moved the %%bash directive above the comments
  • Removed the duplicate %%bash placement

crypdick
crypdick approved these changes Jun 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@crypdick crypdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

angelinalg
angelinalg approved these changes Jun 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@angelinalg angelinalg merged commit 0aed3ed into master Jun 19, 2025
5 checks passed
@angelinalg angelinalg deleted the fix-obj-detection-template-error branch June 19, 2025 04:20
minerharry pushed a commit to minerharry/ray that referenced this pull request Jun 27, 2025
@kunling-anyscale @minerharry
fix the bash code run error in notebook (ray-project#53900)
c8051b4
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
@kunling-anyscale @elliot-barn
fix the bash code run error in notebook (#53900)
0fc1c9c 
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@crypdick crypdick crypdick approved these changes

@angelinalg angelinalg angelinalg approved these changes

Assignees

No one assigned

Labels

docs An issue or change related to documentation go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kunling-anyscale @crypdick @angelinalg