Add dashboard visualizations for TPU metrics#53898
Merged
can-anyscale merged 6 commits intoray-project:masterfrom Jun 18, 2025
Merged
Add dashboard visualizations for TPU metrics#53898can-anyscale merged 6 commits intoray-project:masterfrom
can-anyscale merged 6 commits intoray-project:masterfrom
Conversation
Signed-off-by: Richard Liu <ricliu@google.com>
Signed-off-by: Richard Liu <ricliu@google.com>
Contributor
|
Can you add screenshots of the ray dashboard and the new graphs in the description? |
alanwguo
reviewed
Jun 17, 2025
| targets=[ | ||
| Target( | ||
| expr='sum(ray_tpu_tensorcore_utilization{{instance=~"$Instance",{global_filters}}}) by (instance, TpuIndex, TpuDeviceName)', | ||
| legend="Tensorcore Utilization: {{instance}}, tpu.{{TpuIndex}}, {{TpuType}}, {{TpuTopology}}", |
Contributor
There was a problem hiding this comment.
TpuToplogy won't show up in the label unless it's also part of the sum by expression.
Contributor
Author
|
|
alanwguo
reviewed
Jun 17, 2025
| targets=[ | ||
| Target( | ||
| expr='sum(ray_tpu_tensorcore_utilization{{instance=~"$Instance",{global_filters}}}) by (instance, TpuIndex, TpuDeviceName)', | ||
| legend="Tensorcore Utilization: {{instance}}, tpu.{{TpuIndex}}, {{TpuType}}, {{TpuTopology}}", |
Contributor
There was a problem hiding this comment.
Probably don't need Tensorcore Utilization: in the legend since its the title of the graph itself.
| targets=[ | ||
| Target( | ||
| expr='sum(ray_tpu_memory_bandwidth_utilization{{instance=~"$Instance",{global_filters}}}) by (instance, TpuIndex, TpuDeviceName)', | ||
| legend="Memory Bandwidth Utilization: {{instance}}, tpu.{{TpuIndex}}, {{TpuType}}, {{TpuTopology}}", |
Contributor
There was a problem hiding this comment.
Probably don't need Memory Bandwidth Utilization: in the legend since its the title of the graph itself.
Also for the other graphs as well.
Contributor
Author
There was a problem hiding this comment.
Removed, left the ones for memory used/total since there are two series.
Signed-off-by: Richard Liu <ricliu@google.com>
alanwguo
approved these changes
Jun 18, 2025
Contributor
alanwguo
left a comment
There was a problem hiding this comment.
Thanks lgtm!
@can-anyscale , please review and merge
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? Add dashboard visualizations for TPU metrics ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [X] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [X] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Richard Liu <ricliu@google.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? Add dashboard visualizations for TPU metrics ## Related issue number <!-- For example: "Closes #1234" --> ## Checks - [X] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [X] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Richard Liu <ricliu@google.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add dashboard visualizations for TPU metrics
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.