[Data] Prevent filename collisions on write#53890
Merged
bveeramani merged 11 commits intomasterfrom Jun 19, 2025
Merged
Conversation
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR augments the filename generation API to include a per-write UUID, preventing collisions when re-running jobs in append mode.
- Added
write_uuidparameter to the filename provider interface and implementations - Generated and propagated a UUID through the write planning stage to all write tasks
- Updated tests to pass a fixed
write_uuidand verify deterministic and unique filenames
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| python/ray/data/tests/test_filename_provider.py | Updated tests to include write_uuid in filename calls |
| python/ray/data/datasource/filename_provider.py | Extended provider interface and docs to accept write_uuid |
| python/ray/data/datasource/file_datasink.py | Passed write_uuid into row/block filename generation |
| python/ray/data/_internal/planner/plan_write_op.py | Generated a UUID and attached it to all write tasks |
| python/ray/data/_internal/datasource/parquet_datasink.py | Added write_uuid argument for parquet filename calls |
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
raulchen
approved these changes
Jun 17, 2025
|
|
||
| # Add a UUID to write tasks to prevent filename collisions. This a UUID for the | ||
| # overall write operation, not the individual write tasks. | ||
| write_uuid = uuid.uuid4().hex |
Contributor
There was a problem hiding this comment.
Let's use dataset-id we don't need a different one
Member
Author
There was a problem hiding this comment.
@alexeykudinkin that'd change the way datasets appear in our observability tools. Are we okay that?
I don't mind, but in the interest of speed, I tried to leave that aspect unchanged
Contributor
There was a problem hiding this comment.
Ah, i keep forgetting that we call it uuid, but it's actually not (and we'd fix that madness btw)
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
…nto fix-collisions Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> Currently, Ray Data uses a counter to determine dataset IDs and consequently written filenames. The issue with this approach is that if you re-run a job, Ray Data might re-use the same filenames and override existing data, even if you specify `save_mode="append"`. ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> Currently, Ray Data uses a counter to determine dataset IDs and consequently written filenames. The issue with this approach is that if you re-run a job, Ray Data might re-use the same filenames and override existing data, even if you specify `save_mode="append"`. ## Related issue number <!-- For example: "Closes #1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, Ray Data uses a counter to determine dataset IDs and consequently written filenames. The issue with this approach is that if you re-run a job, Ray Data might re-use the same filenames and override existing data, even if you specify
save_mode="append".Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.