Skip to content

[core] Remove hardcoded flaky tests#53888

Merged
edoakes merged 2 commits intoray-project:masterfrom
edoakes:eoakes/rm-hardcoded-flaky
Jun 17, 2025
Merged

[core] Remove hardcoded flaky tests#53888
edoakes merged 2 commits intoray-project:masterfrom
edoakes:eoakes/rm-hardcoded-flaky

Conversation

@edoakes
Copy link
Copy Markdown
Collaborator

@edoakes edoakes commented Jun 17, 2025

These are no longer flaky 🙌

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested a review from a team as a code owner June 17, 2025 16:05
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Jun 17, 2025
@edoakes edoakes requested a review from can-anyscale June 17, 2025 16:05
@edoakes
Copy link
Copy Markdown
Collaborator Author

edoakes commented Jun 17, 2025

I wasn't sure if deleting the file was safe, so I made the list empty to match others, e.g.,

flaky_tests: []

Copy link
Copy Markdown
Contributor

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the file is safe yes, let's nuke it

@can-anyscale can-anyscale requested a review from khluu June 17, 2025 16:07
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
Copy link
Copy Markdown
Collaborator Author

edoakes commented Jun 17, 2025

Ok, removed it now

@edoakes edoakes merged commit 6224cb3 into ray-project:master Jun 17, 2025
5 checks passed
elliot-barn pushed a commit that referenced this pull request Jun 18, 2025
These are no longer flaky 🙌

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
minerharry pushed a commit to minerharry/ray that referenced this pull request Jun 27, 2025
These are no longer flaky 🙌

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
These are no longer flaky 🙌

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants