[core][gpu-objects] Fix test_gpu_objects_nccl.py#53874
Merged
stephanie-wang merged 1 commit intoray-project:masterfrom Jun 17, 2025
Merged
[core][gpu-objects] Fix test_gpu_objects_nccl.py#53874stephanie-wang merged 1 commit intoray-project:masterfrom
test_gpu_objects_nccl.py#53874stephanie-wang merged 1 commit intoray-project:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with the NCCL GPU objects test by modifying resource allocation in the actor decorator and adjusting test parameters.
- Updated the remote decorator to explicitly set CPU usage to zero.
- Added parameterization to ensure the test runs with two GPUs.
Comments suppressed due to low confidence (2)
python/ray/tests/test_gpu_objects_nccl.py:8
- Consider adding a brief comment explaining the rationale for setting 'num_cpus' to 0, to clarify the resource usage for this GPU-specific actor.
@ray.remote(num_gpus=1, num_cpus=0)
python/ray/tests/test_gpu_objects_nccl.py:18
- Ensure that the CI environment or local setups are configured to support at least 2 GPUs to avoid false negatives in this test.
@pytest.mark.parametrize("ray_start_regular", [{"num_gpus": 2}], indirect=True)
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
#53871 * CI error:  Closes #53871 Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
ray-project#53871 * CI error:  Closes ray-project#53871 Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
#53871 * CI error:  Closes #53871 Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#53871
Related issue number
Closes #53871
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.