[train] expose training input/output in callbacks#53869
Merged
matthewdeng merged 10 commits intoray-project:masterfrom Jun 18, 2025
Merged
[train] expose training input/output in callbacks#53869matthewdeng merged 10 commits intoray-project:masterfrom
matthewdeng merged 10 commits intoray-project:masterfrom
Conversation
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
justinvyu
approved these changes
Jun 18, 2025
Contributor
justinvyu
left a comment
There was a problem hiding this comment.
looks good to me overall!
Comment on lines
+37
to
+38
| # The configuration passed to the training function. | ||
| train_loop_config: Optional[Dict[str, Any]] |
Contributor
There was a problem hiding this comment.
should we also add some metadata like ray version/commit, backend version (torch version)?
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
- Made `TrainRunContext` frozen and added all training inputs (configs, datasets, etc.) - Changed `TrainContext` to contain `TrainRunContext` instead of inheriting from it - Added `after_controller_finish` callback to expose final training results - Modified `after_controller_start` to receive `TrainRunContext` parameter --------- Signed-off-by: Matthew Deng <matt@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
- Made `TrainRunContext` frozen and added all training inputs (configs, datasets, etc.) - Changed `TrainContext` to contain `TrainRunContext` instead of inheriting from it - Added `after_controller_finish` callback to expose final training results - Modified `after_controller_start` to receive `TrainRunContext` parameter --------- Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TrainRunContextfrozen and added all training inputs (configs, datasets, etc.)TrainContextto containTrainRunContextinstead of inheriting from itafter_controller_finishcallback to expose final training resultsafter_controller_startto receiveTrainRunContextparameterTODO
TrainRunContextfrom Callback initializationsTrainContextandTrainRunContext