[data] split test_all_to_all.py#53865
Merged
can-anyscale merged 2 commits intomasterfrom Jun 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR splits the monolithic test_all_to_all.py into several smaller end-to-end tests to speed up runtime by running tests in parallel. The changes include new test files for unique, repartition, random shuffle, map groups, and aggregation functionalities as well as updates in the BUILD file to reflect these changes.
- Splitting tests for aggregation, unique, repartition, random shuffle, and group-by operations.
- Updating the BUILD configuration to assign separate test targets.
- Refactoring test logic for improved parallelism and resource-specific behavior.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| python/ray/data/tests/test_unique_e2e.py | New tests for unique operation and null handling. |
| python/ray/data/tests/test_repartition_e2e.py | New tests for repartition logic with and without shuffling. |
| python/ray/data/tests/test_random_e2e.py | New tests for random shuffle operations and order verification. |
| python/ray/data/tests/test_map_groups_e2e.py | New tests for groupby map operations using GPUs and actors. |
| python/ray/data/tests/test_agg_e2e.py | New tests for aggregation logic and error validation. |
| python/ray/data/BUILD | Updated BUILD configuration to reflect split test targets. |
There was a problem hiding this comment.
[nitpick] Consider adding an explicit assert statement here (e.g., assert ds.schema().names == ["a", "b"]) to validate that the schema is as expected.
Suggested change
| ds.schema().names == ["a", "b"] | |
| assert ds.schema().names == ["a", "b"], "Schema does not match the expected structure ['a', 'b']" |
There was a problem hiding this comment.
[nitpick] When using 'len(keys)' inside check_init, consider explicitly checking the type of 'keys' (e.g. whether it is a list or a string) to make the intent clearer and avoid potential confusion.
Suggested change
| def check_init(k): | |
| def check_init(k): | |
| if not isinstance(keys, (list, str)): | |
| raise TypeError(f"'keys' must be a list or a string, but got {type(keys).__name__}") |
Signed-off-by: can <can@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
The test_all_to_all.py is taking a really long time to finish ([35 minutes](https://buildkite.com/ray-project/postmerge/builds/10883/steps/canvas?jid=0197797e-9c25-4030-a1a6-ff89dba44f8e#0197797e-9c25-4030-a1a6-ff89dba44f8e/176-1023)). I'm breaking this into smaller chunks so they run in parallel. Test: CI Signed-off-by: can <can@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
The test_all_to_all.py is taking a really long time to finish ([35 minutes](https://buildkite.com/ray-project/postmerge/builds/10883/steps/canvas?jid=0197797e-9c25-4030-a1a6-ff89dba44f8e#0197797e-9c25-4030-a1a6-ff89dba44f8e/176-1023)). I'm breaking this into smaller chunks so they run in parallel. Test: CI Signed-off-by: can <can@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
The test_all_to_all.py is taking a really long time to finish ([35 minutes](https://buildkite.com/ray-project/postmerge/builds/10883/steps/canvas?jid=0197797e-9c25-4030-a1a6-ff89dba44f8e#0197797e-9c25-4030-a1a6-ff89dba44f8e/176-1023)). I'm breaking this into smaller chunks so they run in parallel. Test: CI Signed-off-by: can <can@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test_all_to_all.py is taking a really long time to finish (35 minutes). I'm breaking this into smaller chunks so they run in parallel.
Test:
CI