Skip to content

[KubeRay] Remove unused YAMLs#53840

Merged
jjyao merged 1 commit intoray-project:masterfrom
kevin85421:laptop-ray-20250610
Jun 16, 2025
Merged

[KubeRay] Remove unused YAMLs#53840
jjyao merged 1 commit intoray-project:masterfrom
kevin85421:laptop-ray-20250610

Conversation

@kevin85421
Copy link
Copy Markdown
Member

@kevin85421 kevin85421 commented Jun 15, 2025

Why are these changes needed?

After #53833, doc/source/cluster/kubernetes/configs/static-ray-cluster-networkpolicy.yaml and doc/source/cluster/kubernetes/configs/static-ray-cluster.with-fault-tolerance.yaml are no longer used.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Jun 15, 2025
@kevin85421 kevin85421 marked this pull request as ready for review June 16, 2025 04:50
Copilot AI review requested due to automatic review settings June 16, 2025 04:50
@kevin85421 kevin85421 requested review from a team and pcmoritz as code owners June 16, 2025 04:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes three deprecated Kubernetes YAML configurations from the docs that are no longer used after the recent refactoring.

  • Delete unused fault-tolerance config
  • Delete unused network-policy config
  • Delete unused migration example

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
doc/source/cluster/kubernetes/configs/static-ray-cluster.with-fault-tolerance.yaml Remove unused Redis fault-tolerance YAML
doc/source/cluster/kubernetes/configs/static-ray-cluster-networkpolicy.yaml Remove unused network policy YAML
doc/source/cluster/kubernetes/configs/migration-example.yaml Remove unused RayCluster migration example YAML
Comments suppressed due to low confidence (3)

doc/source/cluster/kubernetes/configs/static-ray-cluster.with-fault-tolerance.yaml:1

  • Ensure that all references to static-ray-cluster.with-fault-tolerance.yaml are removed or updated in the documentation to avoid broken links or stale examples.
-# This section is only required for deploying Redis on Kubernetes for the purpose of enabling Ray

doc/source/cluster/kubernetes/configs/static-ray-cluster-networkpolicy.yaml:1

  • Check for any documentation pages or CI scripts that reference static-ray-cluster-networkpolicy.yaml and remove or update those links.
-# If your Kubernetes has a default deny network policy for pods, you need to manually apply this network policy

doc/source/cluster/kubernetes/configs/migration-example.yaml:1

  • Verify that the migration example isn’t referenced elsewhere in the docs or examples directory, and remove any residual pointers to this file.
-apiVersion: ray.io/v1alpha1

@kevin85421
Copy link
Copy Markdown
Member Author

cc @jjyao would you mind merging this PR? Thanks!

@jjyao
Copy link
Copy Markdown
Contributor

jjyao commented Jun 16, 2025

cc @dayshah for code approval.

@jjyao jjyao enabled auto-merge (squash) June 16, 2025 15:50
@jjyao jjyao merged commit b23515d into ray-project:master Jun 16, 2025
6 checks passed
elliot-barn pushed a commit that referenced this pull request Jun 18, 2025
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
minerharry pushed a commit to minerharry/ray that referenced this pull request Jun 27, 2025
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants