[Doc][KubeRay] Remove very old ResNet benchmark example#53839
Merged
[Doc][KubeRay] Remove very old ResNet benchmark example#53839
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes a very old ResNet benchmark example and its related files from the documentation.
- Removed the outdated GPU training example markdown file.
- Removed the corresponding reference in the examples list.
- Deleted the outdated RayCluster GPU configuration and its associated Python job submission script.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| doc/source/cluster/kubernetes/examples/gpu-training-example.md | Removed the entire GPU training example documentation. |
| doc/source/cluster/kubernetes/examples.md | Removed reference to the deleted GPU training example. |
| doc/source/cluster/kubernetes/configs/ray-cluster.gpu.yaml | Deleted the outdated RayCluster configuration for the GPU example. |
| doc/source/cluster/doc_code/pytorch_training_e2e_submit.py | Deleted the Python job submission script for the removed training benchmark. |
MortalHappiness
approved these changes
Jun 16, 2025
Member
Author
|
cc @jjyao would you mind merging this PR? |
Contributor
Could you link the similar examples in the PR description? cc @dayshah for doc approval. |
Member
Author
Done |
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
dayshah
approved these changes
Jun 16, 2025
Member
Author
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
The example still uses Ray 2.2. It is pretty old and KubeRay has already had other similar examples (ex: https://docs.ray.io/en/latest/cluster/kubernetes/examples/mnist-training-example.html#kuberay-mnist-training-example). Remove it from the doc. Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
…53839) The example still uses Ray 2.2. It is pretty old and KubeRay has already had other similar examples (ex: https://docs.ray.io/en/latest/cluster/kubernetes/examples/mnist-training-example.html#kuberay-mnist-training-example). Remove it from the doc. Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
The example still uses Ray 2.2. It is pretty old and KubeRay has already had other similar examples (ex: https://docs.ray.io/en/latest/cluster/kubernetes/examples/mnist-training-example.html#kuberay-mnist-training-example). Remove it from the doc. Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The example still uses Ray 2.2. It is pretty old and KubeRay has already had other similar examples (ex: https://docs.ray.io/en/latest/cluster/kubernetes/examples/mnist-training-example.html#kuberay-mnist-training-example). Remove it from the doc.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.