[Doc] Small mistake in kuberay ingress#53834
Merged
jjyao merged 1 commit intoray-project:masterfrom Jun 15, 2025
Merged
Conversation
Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a documentation mistake in the kuberay ingress guide by updating an incorrect file path in the application command.
- Updated the file path in the "kubectl apply" command to reference the correct YAML file location.
- Removed the outdated file path reference from the command.
Comments suppressed due to low confidence (1)
doc/source/cluster/kubernetes/k8s-ecosystem/ingress.md:194
- Verify that the new command correctly reflects the file path as downloaded and consider adding a short note indicating the expected file location for clarity.
kubectl apply -f ray-cluster.separate-ingress.yaml
kevin85421
approved these changes
Jun 15, 2025
Member
|
@troychiu please ping me when all CI tests pass. |
Contributor
Author
|
@kevin85421 they passed. Thank you! |
Member
|
cc @jjyao would you mind merging this PR? Thanks! |
jjyao
reviewed
Jun 15, 2025
| # and `ray-operator/config/samples/ray-cluster.separate-ingress.yaml` | ||
| curl -LO https://raw.githubusercontent.com/ray-project/kuberay/v1.3.0/ray-operator/config/samples/ray-cluster.separate-ingress.yaml | ||
| kubectl apply -f ray-operator/config/samples/ray-cluster.separate-ingress.yaml | ||
| kubectl apply -f ray-cluster.separate-ingress.yaml |
Contributor
There was a problem hiding this comment.
@kevin85421 can we test this so it can be caught by the CI?
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
This PR update a small mistake in kuberay ingress doc. Signed-off-by: Troy Chiu <y.troychiu@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
This PR update a small mistake in kuberay ingress doc. Signed-off-by: Troy Chiu <y.troychiu@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR update a small mistake in kuberay ingress doc.
Related issue number
N/A
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.